Re: [net-next PATCH 2/3] net: reduce cycles spend on ICMP replies that gets rate limited

2017-06-05 Thread Florian Weimer
On 06/04/2017 04:38 PM, Jesper Dangaard Brouer wrote: > On Sun, 4 Jun 2017 09:11:53 +0200 > Florian Weimer wrote: > >> On 01/09/2017 04:04 PM, Jesper Dangaard Brouer wrote: >> >>> This patch split the global and per (inet)peer ICMP-reply limiter >>> code, and moves the global limit check to earli

Re: [net-next PATCH 2/3] net: reduce cycles spend on ICMP replies that gets rate limited

2017-06-04 Thread Jesper Dangaard Brouer
On Sun, 4 Jun 2017 09:11:53 +0200 Florian Weimer wrote: > On 01/09/2017 04:04 PM, Jesper Dangaard Brouer wrote: > > > This patch split the global and per (inet)peer ICMP-reply limiter > > code, and moves the global limit check to earlier in the packet > > processing path. Thus, avoid spending cy

Re: [net-next PATCH 2/3] net: reduce cycles spend on ICMP replies that gets rate limited

2017-06-04 Thread Florian Weimer
On 01/09/2017 04:04 PM, Jesper Dangaard Brouer wrote: > This patch split the global and per (inet)peer ICMP-reply limiter > code, and moves the global limit check to earlier in the packet > processing path. Thus, avoid spending cycles on ICMP replies that > gets limited/suppressed anyhow. > > The

Re: [net-next PATCH 2/3] net: reduce cycles spend on ICMP replies that gets rate limited

2017-01-11 Thread Eric Dumazet
On Mon, 2017-01-09 at 09:44 -0800, Eric Dumazet wrote: > On Mon, 2017-01-09 at 16:04 +0100, Jesper Dangaard Brouer wrote: > > This patch split the global and per (inet)peer ICMP-reply limiter > > code, and moves the global limit check to earlier in the packet > > processing path. Thus, avoid spend

Re: [net-next PATCH 2/3] net: reduce cycles spend on ICMP replies that gets rate limited

2017-01-09 Thread Eric Dumazet
On Mon, 2017-01-09 at 16:04 +0100, Jesper Dangaard Brouer wrote: > This patch split the global and per (inet)peer ICMP-reply limiter > code, and moves the global limit check to earlier in the packet > processing path. Thus, avoid spending cycles on ICMP replies that > gets limited/suppressed anyho

[net-next PATCH 2/3] net: reduce cycles spend on ICMP replies that gets rate limited

2017-01-09 Thread Jesper Dangaard Brouer
This patch split the global and per (inet)peer ICMP-reply limiter code, and moves the global limit check to earlier in the packet processing path. Thus, avoid spending cycles on ICMP replies that gets limited/suppressed anyhow. The global ICMP rate limiter icmp_global_allow() is a good solution,