Re: [net-next PATCH 0/5] net_sched: Add support for IFE action

2016-02-25 Thread Daniel Borkmann
On 02/25/2016 11:40 PM, Jamal Hadi Salim wrote: On 16-02-25 04:34 PM, Daniel Borkmann wrote: On 02/25/2016 01:23 PM, Jamal Hadi Salim wrote: On 16-02-24 12:48 PM, Daniel Borkmann wrote: On 02/24/2016 01:49 PM, Jamal Hadi Salim wrote: [...] Drivers do set the hash. My use case is slightly dif

Re: [net-next PATCH 0/5] net_sched: Add support for IFE action

2016-02-25 Thread Jamal Hadi Salim
On 16-02-25 04:34 PM, Daniel Borkmann wrote: On 02/25/2016 01:23 PM, Jamal Hadi Salim wrote: On 16-02-24 12:48 PM, Daniel Borkmann wrote: On 02/24/2016 01:49 PM, Jamal Hadi Salim wrote: [...] Drivers do set the hash. My use case is slightly different. I have a NIC which has an embedded cavium

Re: [net-next PATCH 0/5] net_sched: Add support for IFE action

2016-02-25 Thread Daniel Borkmann
On 02/25/2016 01:23 PM, Jamal Hadi Salim wrote: On 16-02-24 12:48 PM, Daniel Borkmann wrote: On 02/24/2016 01:49 PM, Jamal Hadi Salim wrote: [...] Drivers do set the hash. My use case is slightly different. I have a NIC which has an embedded cavium processor. This thing strips off the TLV and

Re: [net-next PATCH 0/5] net_sched: Add support for IFE action

2016-02-25 Thread Jamal Hadi Salim
On 16-02-24 12:58 PM, Daniel Borkmann wrote: On 02/24/2016 01:49 PM, Jamal Hadi Salim wrote: Yes, a bit of that ++. I am between two worlds: There are people who do user space packet processing that claim they do so because they can quickly prototype without compiling the kernel. My goal is to

Re: [net-next PATCH 0/5] net_sched: Add support for IFE action

2016-02-25 Thread Jamal Hadi Salim
On 16-02-24 12:48 PM, Daniel Borkmann wrote: On 02/24/2016 01:49 PM, Jamal Hadi Salim wrote: Drivers do set the hash. My use case is slightly different. I have a NIC which has an embedded cavium processor. This thing strips off the TLV and uses the hash to select the host MSI. Only thing we do

Re: [net-next PATCH 0/5] net_sched: Add support for IFE action

2016-02-24 Thread Daniel Borkmann
On 02/24/2016 01:49 PM, Jamal Hadi Salim wrote: On 16-02-23 10:34 AM, Daniel Borkmann wrote: [...] My concern is we add 20 new modules like this that only do trivial things, where instead they could have been consolidated and reduce maintenance. Or is this hard module requirement related to the

Re: [net-next PATCH 0/5] net_sched: Add support for IFE action

2016-02-24 Thread Daniel Borkmann
On 02/24/2016 01:49 PM, Jamal Hadi Salim wrote: On 16-02-23 10:34 AM, Daniel Borkmann wrote: On 02/23/2016 03:28 PM, Jamal Hadi Salim wrote: [..] These are basic metadata. The question to ask is what could one use skb->hash for. Today it is used to select a cpu to balance to. Right, but tha

Re: [net-next PATCH 0/5] net_sched: Add support for IFE action

2016-02-24 Thread Jamal Hadi Salim
On 16-02-23 10:34 AM, Daniel Borkmann wrote: On 02/23/2016 03:28 PM, Jamal Hadi Salim wrote: [..] These are basic metadata. The question to ask is what could one use skb->hash for. Today it is used to select a cpu to balance to. Right, but that happens before you decode that information from

Re: [net-next PATCH 0/5] net_sched: Add support for IFE action

2016-02-23 Thread Daniel Borkmann
On 02/23/2016 03:28 PM, Jamal Hadi Salim wrote: On 16-02-23 08:20 AM, Daniel Borkmann wrote: On 02/23/2016 01:09 PM, Jamal Hadi Salim wrote: On 16-02-22 11:47 AM, Daniel Borkmann wrote: [...] So, basically this is a L2 encap with TLVs, right? And as TLVs you have skb->mark, skb->priority, sk

Re: [net-next PATCH 0/5] net_sched: Add support for IFE action

2016-02-23 Thread Jamal Hadi Salim
On 16-02-23 08:20 AM, Daniel Borkmann wrote: On 02/23/2016 01:09 PM, Jamal Hadi Salim wrote: On 16-02-22 11:47 AM, Daniel Borkmann wrote: [...] So, basically this is a L2 encap with TLVs, right? And as TLVs you have skb->mark, skb->priority, skb->hash, skb->queue_mapping that you transfer fro

Re: [net-next PATCH 0/5] net_sched: Add support for IFE action

2016-02-23 Thread Daniel Borkmann
On 02/23/2016 01:09 PM, Jamal Hadi Salim wrote: On 16-02-22 11:47 AM, Daniel Borkmann wrote: [...] So, basically this is a L2 encap with TLVs, right? And as TLVs you have skb->mark, skb->priority, skb->hash, skb->queue_mapping that you transfer from one machine to another, where on the destina

Re: [net-next PATCH 0/5] net_sched: Add support for IFE action

2016-02-23 Thread Jamal Hadi Salim
On 16-02-23 02:00 AM, Cong Wang wrote: On Mon, Feb 22, 2016 at 5:21 AM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim As agreed at netconf in Seville, here's the patch finally (1 year was just too long to wait). Described in netdev01 paper: "Distributing Linux Traffic Control C

Re: [net-next PATCH 0/5] net_sched: Add support for IFE action

2016-02-23 Thread Jamal Hadi Salim
Hi Daniel, On 16-02-22 11:47 AM, Daniel Borkmann wrote: Hi Jamal, On 02/22/2016 02:21 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim As agreed at netconf in Seville, here's the patch finally (1 year was just too long to wait). Described in netdev01 paper: "Distributing Linu

Re: [net-next PATCH 0/5] net_sched: Add support for IFE action

2016-02-22 Thread Cong Wang
On Mon, Feb 22, 2016 at 5:21 AM, Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > > As agreed at netconf in Seville, here's the patch finally (1 year > was just too long to wait). > Described in netdev01 paper: > "Distributing Linux Traffic Control Classifier-Action Subsystem" >

Re: [net-next PATCH 0/5] net_sched: Add support for IFE action

2016-02-22 Thread Daniel Borkmann
Hi Jamal, On 02/22/2016 02:21 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim As agreed at netconf in Seville, here's the patch finally (1 year was just too long to wait). Described in netdev01 paper: "Distributing Linux Traffic Control Classifier-Action Subsystem"

[net-next PATCH 0/5] net_sched: Add support for IFE action

2016-02-22 Thread Jamal Hadi Salim
From: Jamal Hadi Salim As agreed at netconf in Seville, here's the patch finally (1 year was just too long to wait). Described in netdev01 paper: "Distributing Linux Traffic Control Classifier-Action Subsystem" Authors: Jamal Hadi Salim and Damascene M. Joachimpillai Al