On Sat, Feb 16, 2019 at 2:51 AM Joe Perches wrote:
>
> On Fri, 2019-02-15 at 10:22 -0800, Eric Dumazet wrote:
> > On Fri, Feb 15, 2019 at 10:13 AM Cong Wang wrote:
> > > On Fri, Feb 15, 2019 at 8:26 AM Eric Dumazet wrote:
> > > > On Fri, Feb 15, 2019 at 6:50 AM Yafang Shao
> > > > wrote:
> > >
On Fri, 2019-02-15 at 10:22 -0800, Eric Dumazet wrote:
> On Fri, Feb 15, 2019 at 10:13 AM Cong Wang wrote:
> > On Fri, Feb 15, 2019 at 8:26 AM Eric Dumazet wrote:
> > > On Fri, Feb 15, 2019 at 6:50 AM Yafang Shao wrote:
> > > > As SOCK_DEBUG() isn't used any more, we can get ride of it now.
> >
On Fri, Feb 15, 2019 at 10:13 AM Cong Wang wrote:
>
> On Fri, Feb 15, 2019 at 8:26 AM Eric Dumazet wrote:
> >
> > On Fri, Feb 15, 2019 at 6:50 AM Yafang Shao wrote:
> > >
> > > As SOCK_DEBUG() isn't used any more, we can get ride of it now.
> > >
> >
> > No, we are still using this infrastructur
On Fri, Feb 15, 2019 at 8:26 AM Eric Dumazet wrote:
>
> On Fri, Feb 15, 2019 at 6:50 AM Yafang Shao wrote:
> >
> > As SOCK_DEBUG() isn't used any more, we can get ride of it now.
> >
>
> No, we are still using this infrastructure from time to time.
>
> I told you I agreed to remove the current (o
On Fri, Feb 15, 2019 at 7:42 AM Yafang Shao wrote:
>
> On Fri, Feb 15, 2019 at 10:58 PM Eric Dumazet wrote:
> >
> > On Fri, Feb 15, 2019 at 6:50 AM Yafang Shao wrote:
> > >
> > > As SOCK_DEBUG() isn't used any more, we can get ride of it now.
> > >
> >
> > No, we are still using this infrastruct
On Fri, Feb 15, 2019 at 10:58 PM Eric Dumazet wrote:
>
> On Fri, Feb 15, 2019 at 6:50 AM Yafang Shao wrote:
> >
> > As SOCK_DEBUG() isn't used any more, we can get ride of it now.
> >
>
> No, we are still using this infrastructure from time to time.
>
> I told you I agreed to remove the current (
On Fri, Feb 15, 2019 at 6:50 AM Yafang Shao wrote:
>
> As SOCK_DEBUG() isn't used any more, we can get ride of it now.
>
No, we are still using this infrastructure from time to time.
I told you I agreed to remove the current (obsolete) TCP call sites,
I never suggested to remove SOCK_DEBUG() co
As SOCK_DEBUG() isn't used any more, we can get ride of it now.
Regarding the SO_DEBUG in sock_{s,g}etsockopt, I think it is better to
keep as-is, because if we return an errno to tell the application that
this optname isn't supported, it may break the application.
The application still can use th
