Re: [net-next 4/8] net/mlx5e: Add device out of buffer counter

2019-08-26 Thread Saeed Mahameed
On Mon, 2019-08-26 at 13:39 -0700, Jakub Kicinski wrote: > On Mon, 26 Aug 2019 20:14:47 +, Saeed Mahameed wrote: > > > I see thanks for the explanation and sorry for the delayed > > > response. > > > Would it perhaps make sense to indicate the hairpin in the > > > name? > > > > We had some i

Re: [net-next 4/8] net/mlx5e: Add device out of buffer counter

2019-08-26 Thread Jakub Kicinski
On Mon, 26 Aug 2019 20:14:47 +, Saeed Mahameed wrote: > > I see thanks for the explanation and sorry for the delayed response. > > Would it perhaps make sense to indicate the hairpin in the name? > > We had some internal discussion and we couldn't come up with the > perfect name :) > > hair

Re: [net-next 4/8] net/mlx5e: Add device out of buffer counter

2019-08-26 Thread Saeed Mahameed
On Fri, 2019-08-23 at 11:16 -0700, Jakub Kicinski wrote: > On Fri, 23 Aug 2019 06:00:45 +, Saeed Mahameed wrote: > > On Thu, 2019-08-22 at 18:33 -0700, Jakub Kicinski wrote: > > > On Thu, 22 Aug 2019 23:35:52 +, Saeed Mahameed wrote: > > > > From: Moshe Shemesh > > > > > > > > Added the

Re: [net-next 4/8] net/mlx5e: Add device out of buffer counter

2019-08-23 Thread Jakub Kicinski
On Fri, 23 Aug 2019 06:00:45 +, Saeed Mahameed wrote: > On Thu, 2019-08-22 at 18:33 -0700, Jakub Kicinski wrote: > > On Thu, 22 Aug 2019 23:35:52 +, Saeed Mahameed wrote: > > > From: Moshe Shemesh > > > > > > Added the following packets drop counter: > > > Device out of buffer - counts

Re: [net-next 4/8] net/mlx5e: Add device out of buffer counter

2019-08-22 Thread Saeed Mahameed
On Thu, 2019-08-22 at 18:33 -0700, Jakub Kicinski wrote: > On Thu, 22 Aug 2019 23:35:52 +, Saeed Mahameed wrote: > > From: Moshe Shemesh > > > > Added the following packets drop counter: > > Device out of buffer - counts packets which were dropped due to > > full > > device internal receive q

Re: [net-next 4/8] net/mlx5e: Add device out of buffer counter

2019-08-22 Thread Jakub Kicinski
On Thu, 22 Aug 2019 23:35:52 +, Saeed Mahameed wrote: > From: Moshe Shemesh > > Added the following packets drop counter: > Device out of buffer - counts packets which were dropped due to full > device internal receive queue. > This counter will be shown on ethtool as a new counter called > d

[net-next 4/8] net/mlx5e: Add device out of buffer counter

2019-08-22 Thread Saeed Mahameed
From: Moshe Shemesh Added the following packets drop counter: Device out of buffer - counts packets which were dropped due to full device internal receive queue. This counter will be shown on ethtool as a new counter called dev_out_of_buffer. The counter is read from FW by command QUERY_VNIC_ENV.