On Fri, Jun 28, 2019 at 7:44 PM Florian Fainelli wrote:
>
>
>
> On 6/26/2019 11:52 AM, Catherine Sullivan wrote:
>
> [snip]
>
> > +static void
> > +gve_get_ethtool_stats(struct net_device *netdev,
> > + struct ethtool_stats *stats, u64 *data)
> > +{
> > + struct gve_priv *pri
Hi Catherine,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Catherine-Sullivan/Add-gve-driver/20190629-070444
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-rc1-7-g2b96
On 6/26/2019 11:52 AM, Catherine Sullivan wrote:
[snip]
> +static void
> +gve_get_ethtool_stats(struct net_device *netdev,
> + struct ethtool_stats *stats, u64 *data)
> +{
> + struct gve_priv *priv = netdev_priv(netdev);
> + u64 rx_pkts, rx_bytes, tx_pkts, tx_bytes;
>
On Wed, Jun 26, 2019 at 12:48 PM Andrew Lunn wrote:
>
> > +static int gve_get_sset_count(struct net_device *netdev, int sset)
> > +{
> > + struct gve_priv *priv = netdev_priv(netdev);
> > +
> > + if (!netif_carrier_ok(netdev))
> > + return 0;
>
> That is pretty unusual. What go
> +static int gve_get_sset_count(struct net_device *netdev, int sset)
> +{
> + struct gve_priv *priv = netdev_priv(netdev);
> +
> + if (!netif_carrier_ok(netdev))
> + return 0;
That is pretty unusual. What goes wrong if there is no carrier and
statistics are returned?
> +stati
Add support for the following ethtool commands:
ethtool -s|--change devname [msglvl N] [msglevel type on|off]
ethtool -S|--statistics devname
ethtool -i|--driver devname
ethtool -l|--show-channels devname
ethtool -L|--set-channels devname
ethtool -g|--show-ring devname
ethtool --reset devname
Sig
