Re: [net-next 2/7] igb: add rx drop enable attribute

2019-10-17 Thread Jakub Kicinski
On Thu, 17 Oct 2019 18:04:22 +0100, Robert Beckett wrote: > On Thu, 2019-10-17 at 08:44 -0700, Jakub Kicinski wrote: > > On Thu, 17 Oct 2019 12:24:03 +0100, Robert Beckett wrote: > > > On Wed, 2019-10-16 at 16:55 -0700, Jakub Kicinski wrote: > > > > On Wed, 16 Oct 2019 16:47:06 -0700, Jeff Kirs

Re: [net-next 2/7] igb: add rx drop enable attribute

2019-10-17 Thread Robert Beckett
On Thu, 2019-10-17 at 08:44 -0700, Jakub Kicinski wrote: > On Thu, 17 Oct 2019 12:24:03 +0100, Robert Beckett wrote: > > On Wed, 2019-10-16 at 16:55 -0700, Jakub Kicinski wrote: > > > On Wed, 16 Oct 2019 16:47:06 -0700, Jeff Kirsher wrote: > > > > From: Robert Beckett > > > > > > > > To allow u

Re: [net-next 2/7] igb: add rx drop enable attribute

2019-10-17 Thread Jakub Kicinski
On Thu, 17 Oct 2019 12:24:03 +0100, Robert Beckett wrote: > On Wed, 2019-10-16 at 16:55 -0700, Jakub Kicinski wrote: > > On Wed, 16 Oct 2019 16:47:06 -0700, Jeff Kirsher wrote: > > > From: Robert Beckett > > > > > > To allow userland to enable or disable dropping packets when > > > descriptor >

Re: [net-next 2/7] igb: add rx drop enable attribute

2019-10-17 Thread Robert Beckett
On Wed, 2019-10-16 at 16:55 -0700, Jakub Kicinski wrote: > On Wed, 16 Oct 2019 16:47:06 -0700, Jeff Kirsher wrote: > > From: Robert Beckett > > > > To allow userland to enable or disable dropping packets when > > descriptor > > ring is exhausted, add RX_DROP_EN private flag. > > > > This can be

Re: [net-next 2/7] igb: add rx drop enable attribute

2019-10-16 Thread Jakub Kicinski
On Wed, 16 Oct 2019 16:47:06 -0700, Jeff Kirsher wrote: > From: Robert Beckett > > To allow userland to enable or disable dropping packets when descriptor > ring is exhausted, add RX_DROP_EN private flag. > > This can be used in conjunction with flow control to mitigate packet storms > (e.g. due

[net-next 2/7] igb: add rx drop enable attribute

2019-10-16 Thread Jeff Kirsher
From: Robert Beckett To allow userland to enable or disable dropping packets when descriptor ring is exhausted, add RX_DROP_EN private flag. This can be used in conjunction with flow control to mitigate packet storms (e.g. due to network loop or DoS) by forcing the network adapter to send pause