Hi Catherine,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Catherine-Sullivan/Add-gve-driver/20190629-070444
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reprodu
Hi Catherine,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Catherine-Sullivan/Add-gve-driver/20190629-070444
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-rc1-7-g2b96
On Wed, Jun 26, 2019 at 12:42 PM Andrew Lunn wrote:
>
> > +static int gve_change_mtu(struct net_device *dev, int new_mtu)
> > +{
> > + dev->mtu = new_mtu;
> > + return 0;
> > +}
>
> The default implementation does this.
>
> Also, i think your mtu has a limit of PAGE size. So you should se
On Wed, Jun 26, 2019 at 12:49 PM David Miller wrote:
>
> From: Catherine Sullivan
> Date: Wed, 26 Jun 2019 11:52:49 -0700
>
> > +#ifdef __LITTLE_ENDIAN
> > +#define GVE_SEQNO(x) __force u16)x) >> 8) & 0x7)
> > +#else
> > +#define GVE_SEQNO(x) ((__force u16)(x) & 0x7)
> > +#endif
>
> This
From: Catherine Sullivan
Date: Wed, 26 Jun 2019 11:52:49 -0700
> +#ifdef __LITTLE_ENDIAN
> +#define GVE_SEQNO(x) __force u16)x) >> 8) & 0x7)
> +#else
> +#define GVE_SEQNO(x) ((__force u16)(x) & 0x7)
> +#endif
This can be simply "le16_to_cpu(x) & 0x7" or similar. No need to
messy ifdefs
> +static int gve_change_mtu(struct net_device *dev, int new_mtu)
> +{
> + dev->mtu = new_mtu;
> + return 0;
> +}
The default implementation does this.
Also, i think your mtu has a limit of PAGE size. So you should set
the dev->max_mtu so the core will enforce this.
Andrew
Add support for passing traffic.
Signed-off-by: Catherine Sullivan
Signed-off-by: Sagi Shahar
Signed-off-by: Jon Olson
Acked-by: Willem de Bruijn
Reviewed-by: Luigi Rizzo
---
.../networking/device_drivers/google/gve.rst | 30 +
drivers/net/ethernet/google/gve/Makefile | 2 +-
driver
