Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-24 Thread Ido Schimmel
Hi Jakub, On Wed, May 23, 2018 at 02:23:14AM -0700, Jakub Kicinski wrote: > Are you referring to XOFF/XON thresholds? I don't think the "threshold > type" in devlink API implies we are setting XON/XOFF thresholds > directly :S If PFC is enabled we may be setting them indirectly, > obviously. >

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-24 Thread Huy Nguyen
On 5/23/2018 11:03 AM, John Fastabend wrote: On 05/23/2018 08:37 AM, Huy Nguyen wrote: On 5/23/2018 8:52 AM, John Fastabend wrote: It would be nice though if the API gave us some hint on max/min/stride of allowed values. Could the get API return these along with current value? Presumably the a

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-24 Thread Huy Nguyen
On 5/23/2018 3:19 PM, Jakub Kicinski wrote: On Mon, 21 May 2018 14:04:57 -0700, Saeed Mahameed wrote: diff --git a/include/uapi/linux/dcbnl.h b/include/uapi/linux/dcbnl.h index 2c0c6453c3f4..1ddc0a44c172 100644 --- a/include/uapi/linux/dcbnl.h +++ b/include/uapi/linux/dcbnl.h @@ -163,6 +163,15

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-23 Thread Jakub Kicinski
On Wed, 23 May 2018 09:03:53 -0700, John Fastabend wrote: > On 05/23/2018 08:37 AM, Huy Nguyen wrote: > > > > > > On 5/23/2018 8:52 AM, John Fastabend wrote: > >> It would be nice though if the API gave us some hint on max/min/stride > >> of allowed values. Could the get API return these along

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-23 Thread Jakub Kicinski
On Mon, 21 May 2018 14:04:57 -0700, Saeed Mahameed wrote: > diff --git a/include/uapi/linux/dcbnl.h b/include/uapi/linux/dcbnl.h > index 2c0c6453c3f4..1ddc0a44c172 100644 > --- a/include/uapi/linux/dcbnl.h > +++ b/include/uapi/linux/dcbnl.h > @@ -163,6 +163,15 @@ struct ieee_pfc { > __u64 i

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-23 Thread Jakub Kicinski
On Wed, 23 May 2018 06:52:33 -0700, John Fastabend wrote: > On 05/23/2018 02:43 AM, Jiri Pirko wrote: > > Tue, May 22, 2018 at 07:20:26AM CEST, jakub.kicin...@netronome.com wrote: > >> On Mon, 21 May 2018 14:04:57 -0700, Saeed Mahameed wrote: > >>> From: Huy Nguyen > >>> > >>> In this patch, w

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-23 Thread John Fastabend
On 05/23/2018 08:37 AM, Huy Nguyen wrote: > > > On 5/23/2018 8:52 AM, John Fastabend wrote: >> It would be nice though if the API gave us some hint on max/min/stride >> of allowed values. Could the get API return these along with current >> value? Presumably the allowed max size could change with

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-23 Thread Huy Nguyen
On 5/23/2018 8:52 AM, John Fastabend wrote: It would be nice though if the API gave us some hint on max/min/stride of allowed values. Could the get API return these along with current value? Presumably the allowed max size could change with devlink buffer changes in how the global buffer is div

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-23 Thread Huy Nguyen
On 5/23/2018 4:23 AM, Jakub Kicinski wrote: >From patch description it seems like your default setup is shared buffer split 50% (lossy)/50% (all prios) and the example you give changes that to 25% (lossy)/25%x3 prio groups. With existing devlink API could this be modelled by three ingress pool

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-23 Thread Huy Nguyen
I hope that is not true, since we (Netronome) are trying to use it for NIC configuration, too. We should generalize the API if need be. Yes, it is up to your company. devlink is static tool. DCBNL are intended to be dynamically configured by switch. In real world, not many people configure NIC'

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-23 Thread John Fastabend
On 05/23/2018 02:43 AM, Jiri Pirko wrote: > Tue, May 22, 2018 at 07:20:26AM CEST, jakub.kicin...@netronome.com wrote: >> On Mon, 21 May 2018 14:04:57 -0700, Saeed Mahameed wrote: >>> From: Huy Nguyen >>> >>> In this patch, we add dcbnl buffer attribute to allow user >>> change the NIC's buffer con

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-23 Thread Jiri Pirko
Tue, May 22, 2018 at 07:20:26AM CEST, jakub.kicin...@netronome.com wrote: >On Mon, 21 May 2018 14:04:57 -0700, Saeed Mahameed wrote: >> From: Huy Nguyen >> >> In this patch, we add dcbnl buffer attribute to allow user >> change the NIC's buffer configuration such as priority >> to buffer mapping

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-23 Thread Jiri Pirko
Wed, May 23, 2018 at 11:23:14AM CEST, jakub.kicin...@netronome.com wrote: >On Tue, 22 May 2018 20:01:21 -0500, Huy Nguyen wrote: >> On 5/22/2018 1:32 PM, Jakub Kicinski wrote: >> > On Tue, 22 May 2018 10:36:17 -0500, Huy Nguyen wrote: >> >> On 5/22/2018 12:20 AM, Jakub Kicinski wrote: >> >>> On

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-23 Thread Jakub Kicinski
On Tue, 22 May 2018 20:01:21 -0500, Huy Nguyen wrote: > On 5/22/2018 1:32 PM, Jakub Kicinski wrote: > > On Tue, 22 May 2018 10:36:17 -0500, Huy Nguyen wrote: > >> On 5/22/2018 12:20 AM, Jakub Kicinski wrote: > >>> On Mon, 21 May 2018 14:04:57 -0700, Saeed Mahameed wrote: > From: Huy Nguy

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-22 Thread Or Gerlitz
On Wed, May 23, 2018 at 4:01 AM, Huy Nguyen wrote: > Dear Jakub, PSB. > On 5/22/2018 1:32 PM, Jakub Kicinski wrote: >> Devlink API accommodates requirements of simpler (SwitchX2?) and more >> advanced schemes (present in Spectrum). The simpler/basic static >> threshold configurations is exactly

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-22 Thread Huy Nguyen
Dear Jakub, PSB. On 5/22/2018 1:32 PM, Jakub Kicinski wrote: On Tue, 22 May 2018 10:36:17 -0500, Huy Nguyen wrote: On 5/22/2018 12:20 AM, Jakub Kicinski wrote: On Mon, 21 May 2018 14:04:57 -0700, Saeed Mahameed wrote: From: Huy Nguyen In this patch, we add dcbnl buffer attribute to allow us

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-22 Thread Jakub Kicinski
On Tue, 22 May 2018 10:36:17 -0500, Huy Nguyen wrote: > On 5/22/2018 12:20 AM, Jakub Kicinski wrote: > > On Mon, 21 May 2018 14:04:57 -0700, Saeed Mahameed wrote: > >> From: Huy Nguyen > >> > >> In this patch, we add dcbnl buffer attribute to allow user > >> change the NIC's buffer configuration

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-22 Thread Huy Nguyen
On 5/22/2018 12:20 AM, Jakub Kicinski wrote: On Mon, 21 May 2018 14:04:57 -0700, Saeed Mahameed wrote: From: Huy Nguyen In this patch, we add dcbnl buffer attribute to allow user change the NIC's buffer configuration such as priority to buffer mapping and buffer size of individual buffer. Thi

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-21 Thread Jakub Kicinski
On Mon, 21 May 2018 14:04:57 -0700, Saeed Mahameed wrote: > From: Huy Nguyen > > In this patch, we add dcbnl buffer attribute to allow user > change the NIC's buffer configuration such as priority > to buffer mapping and buffer size of individual buffer. > > This attribute combined with pfc attr

[net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-21 Thread Saeed Mahameed
From: Huy Nguyen In this patch, we add dcbnl buffer attribute to allow user change the NIC's buffer configuration such as priority to buffer mapping and buffer size of individual buffer. This attribute combined with pfc attribute allows advance user to fine tune the qos setting for specific prio