Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-28 Thread Juergen Gross
On 28.03.21 22:46, Hsu, Chiahao wrote: Leon Romanovsky 於 2021/3/22 08:13 寫道: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On Mon, Mar 22, 2021 at 08:01:17AM +0100, Jü

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-28 Thread Hsu, Chiahao
Leon Romanovsky 於 2021/3/22 08:13 寫道: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On Mon, Mar 22, 2021 at 08:01:17AM +0100, Jürgen Groß wrote: On 22.03.21 07:48, Le

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-22 Thread Leon Romanovsky
On Mon, Mar 22, 2021 at 08:01:17AM +0100, Jürgen Groß wrote: > On 22.03.21 07:48, Leon Romanovsky wrote: > > On Mon, Mar 22, 2021 at 06:58:34AM +0100, Jürgen Groß wrote: > > > On 22.03.21 06:39, Leon Romanovsky wrote: > > > > On Sun, Mar 21, 2021 at 06:54:52PM +0100, Hsu, Chiahao wrote: > > > > >

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-22 Thread Jürgen Groß
On 22.03.21 07:48, Leon Romanovsky wrote: On Mon, Mar 22, 2021 at 06:58:34AM +0100, Jürgen Groß wrote: On 22.03.21 06:39, Leon Romanovsky wrote: On Sun, Mar 21, 2021 at 06:54:52PM +0100, Hsu, Chiahao wrote: <...> Typically there should be one VM running netback on each host, and having co

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-21 Thread Leon Romanovsky
On Mon, Mar 22, 2021 at 06:58:34AM +0100, Jürgen Groß wrote: > On 22.03.21 06:39, Leon Romanovsky wrote: > > On Sun, Mar 21, 2021 at 06:54:52PM +0100, Hsu, Chiahao wrote: > > > > > > > <...> > > > > > > > Typically there should be one VM running netback on each host, > > > > > and having control

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-21 Thread Jürgen Groß
On 22.03.21 06:39, Leon Romanovsky wrote: On Sun, Mar 21, 2021 at 06:54:52PM +0100, Hsu, Chiahao wrote: <...> Typically there should be one VM running netback on each host, and having control over what interfaces or features it exposes is also important for stability. How about we create a

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-21 Thread Leon Romanovsky
On Sun, Mar 21, 2021 at 06:54:52PM +0100, Hsu, Chiahao wrote: > <...> > > > Typically there should be one VM running netback on each host, > > > and having control over what interfaces or features it exposes is also > > > important for stability. > > > How about we create a 'feature flags' modpa

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-21 Thread Hsu, Chiahao
Andrew Lunn 於 2021/3/21 21:29 寫道: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. At the end, it will be more granular module parameter that user still will need to gue

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-21 Thread Andrew Lunn
> > At the end, it will be more granular module parameter that user still > > will need to guess. > I believe users always need to know any parameter or any tool's flag before > they use it. > For example, before user try to set/clear this ctrl_ring_enabled, they > should already have basic knowled

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-21 Thread Hsu, Chiahao
Leon Romanovsky 於 2021/3/21 18:22 寫道: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On Sun, Mar 21, 2021 at 05:31:08PM +0100, Hsu, Chiahao wrote: Leon Romanovsky 於 2

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-21 Thread Leon Romanovsky
On Sun, Mar 21, 2021 at 05:31:08PM +0100, Hsu, Chiahao wrote: > > > Leon Romanovsky 於 2021/3/17 18:22 寫道: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know > > the content is safe. > > > >

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-21 Thread Hsu, Chiahao
Leon Romanovsky 於 2021/3/17 18:22 寫道: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On Tue, Mar 16, 2021 at 04:22:21PM +0100, Hsu, Chiahao wrote: Leon Romanovsky 於 2

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-17 Thread Leon Romanovsky
On Tue, Mar 16, 2021 at 04:22:21PM +0100, Hsu, Chiahao wrote: > > > Leon Romanovsky 於 2021/3/14 11:04 寫道: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know > > the content is safe. > > > > > >

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-16 Thread Hsu, Chiahao
Leon Romanovsky 於 2021/3/14 11:04 寫道: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On Fri, Mar 12, 2021 at 09:36:59PM +0100, Andrew Lunn wrote: On Fri, Mar 12, 2021

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-14 Thread Leon Romanovsky
On Fri, Mar 12, 2021 at 09:36:59PM +0100, Andrew Lunn wrote: > On Fri, Mar 12, 2021 at 04:18:02PM +0100, Hsu, Chiahao wrote: > > > > Andrew Lunn 於 2021/3/12 15:52 寫道: > > > CAUTION: This email originated from outside of the organization. Do not > > > click links or open attachments unless you can

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-12 Thread Andrew Lunn
On Fri, Mar 12, 2021 at 04:18:02PM +0100, Hsu, Chiahao wrote: > > Andrew Lunn 於 2021/3/12 15:52 寫道: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know > > the content is safe. > > > > > > >

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-12 Thread Hsu, Chiahao
Andrew Lunn 於 2021/3/12 15:52 寫道: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On Thu, Mar 11, 2021 at 10:59:44PM +, ChiaHao Hsu wrote: In order to support live m

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-12 Thread Andrew Lunn
On Thu, Mar 11, 2021 at 10:59:44PM +, ChiaHao Hsu wrote: > In order to support live migration of guests between kernels > that do and do not support 'feature-ctrl-ring', we add a > module parameter that allows the feature to be disabled > at run time, instead of using hardcode value. > The defa

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-11 Thread Paul Durrant
On 11/03/2021 22:59, ChiaHao Hsu wrote: In order to support live migration of guests between kernels that do and do not support 'feature-ctrl-ring', we add a module parameter that allows the feature to be disabled at run time, instead of using hardcode value. The default value is enable. Signed-

[net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-11 Thread ChiaHao Hsu
In order to support live migration of guests between kernels that do and do not support 'feature-ctrl-ring', we add a module parameter that allows the feature to be disabled at run time, instead of using hardcode value. The default value is enable. Signed-off-by: ChiaHao Hsu --- drivers/net/xen-