Re: [net-next 1/1] tipc: avoid unnecessary copying of bundled messages

2018-02-16 Thread David Miller
From: Jon Maloy Date: Thu, 15 Feb 2018 08:57:14 + > The buffers we are cloning are linearized 1 MTU incoming > buffers. There are no fragments. Each clone normally points to only > a tiny fraction of the data area of the base buffer. I don't claim > that copying always is bad, but in this c

RE: [net-next 1/1] tipc: avoid unnecessary copying of bundled messages

2018-02-15 Thread Jon Maloy
uyen > ; Hoang Huu Le > ; Canh Duc Luu > ; Ying Xue ; tipc- > discuss...@lists.sourceforge.net > Subject: Re: [net-next 1/1] tipc: avoid unnecessary copying of bundled > messages > > From: Jon Maloy > Date: Wed, 14 Feb 2018 13:50:31 +0100 > > > diff --git

Re: [net-next 1/1] tipc: avoid unnecessary copying of bundled messages

2018-02-14 Thread David Miller
From: Jon Maloy Date: Wed, 14 Feb 2018 13:50:31 +0100 > diff --git a/net/tipc/msg.c b/net/tipc/msg.c > index 4e1c6f6..a368fa8 100644 > --- a/net/tipc/msg.c > +++ b/net/tipc/msg.c > @@ -434,6 +434,9 @@ bool tipc_msg_extract(struct sk_buff *skb, struct sk_buff > **iskb, int *pos) > skb_pull(

Re: [net-next 1/1] tipc: avoid unnecessary copying of bundled messages

2018-02-14 Thread Eric Dumazet
On Wed, 2018-02-14 at 13:50 +0100, Jon Maloy wrote: > A received sk buffer may contain dozens of smaller 'bundled' messages > which after extraction go each in their own direction. > > Unfortunately, when we extract those messages using skb_clone() each > of the extracted buffers inherit the trues

[net-next 1/1] tipc: avoid unnecessary copying of bundled messages

2018-02-14 Thread Jon Maloy
A received sk buffer may contain dozens of smaller 'bundled' messages which after extraction go each in their own direction. Unfortunately, when we extract those messages using skb_clone() each of the extracted buffers inherit the truesize value of the original buffer. Apart from causing massive o