RE: [net-next 06/15] ixgbe: fix PTP SDP pin setup on X540 hardware

2019-06-07 Thread Keller, Jacob E
...@redhat.com; sassm...@redhat.com; Bowers, > AndrewX > Subject: Re: [net-next 06/15] ixgbe: fix PTP SDP pin setup on X540 hardware > > On Thu, Jun 06, 2019 at 08:37:59PM +, Keller, Jacob E wrote: > > No. We use the timecounter to track the time offset, not the > > fre

Re: [net-next 06/15] ixgbe: fix PTP SDP pin setup on X540 hardware

2019-06-06 Thread Richard Cochran
On Thu, Jun 06, 2019 at 08:37:59PM +, Keller, Jacob E wrote: > No. We use the timecounter to track the time offset, not the > frequency. That is, our hardware can't represent 64bits of time, but > it can adjust frequency. The time counter is used to track the > adjustments from adjtime and set

RE: [net-next 06/15] ixgbe: fix PTP SDP pin setup on X540 hardware

2019-06-06 Thread Keller, Jacob E
...@redhat.com; sassm...@redhat.com; Bowers, > AndrewX > Subject: Re: [net-next 06/15] ixgbe: fix PTP SDP pin setup on X540 hardware > > On Wed, Jun 05, 2019 at 01:23:49PM -0700, Jeff Kirsher wrote: > > + * It calculates when the system time will be on an exact second, and t

Re: [net-next 06/15] ixgbe: fix PTP SDP pin setup on X540 hardware

2019-06-05 Thread Richard Cochran
On Wed, Jun 05, 2019 at 01:23:49PM -0700, Jeff Kirsher wrote: > + * It calculates when the system time will be on an exact second, and then > + * aligns the start of the PPS signal to that value. > + * > + * This works by using the cycle counter shift and mult values in reverse, > and > + * assume

[net-next 06/15] ixgbe: fix PTP SDP pin setup on X540 hardware

2019-06-05 Thread Jeff Kirsher
From: Jacob Keller The function ixgbe_ptp_setup_sdp_X540 attempts to program a software defined pin, in order to generate a pulse-per-second output on SDP 0. It does work to generate the output, but does not align the output on the full second. Additionally, it does not take into account the cyc