Re: [net-next 03/15] net/mlx5e: PFC stall prevention support

2018-03-27 Thread Gal Pressman
On 25-Mar-18 19:18, Andrew Lunn wrote: >>> Shouldn't you map a value of MLX5E_PFC_PREVEN_AUTO_TOUT_MSEC back to >>> PFC_STORM_PREVENTION_AUTO? >> >> We discussed this point internally, mapping MLX5E_PFC_PREVEN_AUTO_TOUT_MSEC >> (100) to >> PFC_STORM_PREVENTION_AUTO might cause confusion when the

Re: [net-next 03/15] net/mlx5e: PFC stall prevention support

2018-03-25 Thread Andrew Lunn
> > Shouldn't you map a value of MLX5E_PFC_PREVEN_AUTO_TOUT_MSEC back to > > PFC_STORM_PREVENTION_AUTO? > > We discussed this point internally, mapping MLX5E_PFC_PREVEN_AUTO_TOUT_MSEC > (100) to > PFC_STORM_PREVENTION_AUTO might cause confusion when the user explicitly asks > for 100msec timeou

Re: [net-next 03/15] net/mlx5e: PFC stall prevention support

2018-03-25 Thread Gal Pressman
On 24-Mar-18 18:07, Andrew Lunn wrote: > On Fri, Mar 23, 2018 at 03:39:13PM -0700, Saeed Mahameed wrote: >> From: Inbar Karmy >> >> Implement set/get functions to configure PFC stall prevention >> timeout by tunables api through ethtool. >> By default the stall prevention timeout is configured to

Re: [net-next 03/15] net/mlx5e: PFC stall prevention support

2018-03-24 Thread Andrew Lunn
On Fri, Mar 23, 2018 at 03:39:13PM -0700, Saeed Mahameed wrote: > From: Inbar Karmy > > Implement set/get functions to configure PFC stall prevention > timeout by tunables api through ethtool. > By default the stall prevention timeout is configured to 8 sec. > Timeout range is: 80-8000 msec. > En

[net-next 03/15] net/mlx5e: PFC stall prevention support

2018-03-23 Thread Saeed Mahameed
From: Inbar Karmy Implement set/get functions to configure PFC stall prevention timeout by tunables api through ethtool. By default the stall prevention timeout is configured to 8 sec. Timeout range is: 80-8000 msec. Enabling stall prevention without a specific timeout will set the timeout to 100