Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-22 Thread Yuchung Cheng
On Tue, Oct 22, 2019 at 12:34 PM Jason Baron wrote: > > > > On 10/22/19 2:17 PM, Yuchung Cheng wrote: > > On Mon, Oct 21, 2019 at 7:14 PM Neal Cardwell wrote: > >> > >> On Mon, Oct 21, 2019 at 5:11 PM Jason Baron wrote: > >>> > >>> > >>> > >>> On 10/21/19 4:36 PM, Eric Dumazet wrote: > On M

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-22 Thread Jason Baron
On 10/22/19 2:17 PM, Yuchung Cheng wrote: > On Mon, Oct 21, 2019 at 7:14 PM Neal Cardwell wrote: >> >> On Mon, Oct 21, 2019 at 5:11 PM Jason Baron wrote: >>> >>> >>> >>> On 10/21/19 4:36 PM, Eric Dumazet wrote: On Mon, Oct 21, 2019 at 12:53 PM Christoph Paasch wrote: > >>>

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-22 Thread Yuchung Cheng
On Mon, Oct 21, 2019 at 7:14 PM Neal Cardwell wrote: > > On Mon, Oct 21, 2019 at 5:11 PM Jason Baron wrote: > > > > > > > > On 10/21/19 4:36 PM, Eric Dumazet wrote: > > > On Mon, Oct 21, 2019 at 12:53 PM Christoph Paasch > > > wrote: > > >> > > > > > >> Actually, longterm I hope we would be abl

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-21 Thread Neal Cardwell
On Mon, Oct 21, 2019 at 5:11 PM Jason Baron wrote: > > > > On 10/21/19 4:36 PM, Eric Dumazet wrote: > > On Mon, Oct 21, 2019 at 12:53 PM Christoph Paasch wrote: > >> > > > >> Actually, longterm I hope we would be able to get rid of the > >> blackhole-detection and fallback heuristics. In a far di

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-21 Thread Christoph Paasch
On 21/10/19 - 14:27:24, Jason Baron wrote: > > > On 10/21/19 2:02 PM, Yuchung Cheng wrote: > > Thanks for the patch. Detailed comments below > > > > On Fri, Oct 18, 2019 at 4:58 PM Neal Cardwell wrote: > >> > >> On Fri, Oct 18, 2019 at 3:03 PM Jason Baron wrote: > >>> > >>> The TCPI_OPT_SYN_DA

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-21 Thread Jason Baron
On 10/21/19 4:36 PM, Eric Dumazet wrote: > On Mon, Oct 21, 2019 at 12:53 PM Christoph Paasch wrote: >> > >> Actually, longterm I hope we would be able to get rid of the >> blackhole-detection and fallback heuristics. In a far distant future where >> these middleboxes have been weeded out ;-) >

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-21 Thread Eric Dumazet
On Mon, Oct 21, 2019 at 12:53 PM Christoph Paasch wrote: > > Actually, longterm I hope we would be able to get rid of the > blackhole-detection and fallback heuristics. In a far distant future where > these middleboxes have been weeded out ;-) > > So, do we really want to eternalize this as part

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-21 Thread William Dauchy
Hello Eric, On Mon, Oct 21, 2019 at 9:02 PM Eric Dumazet wrote: > Reporting tsval/tsecr values were not well defined and seemed quite > experimental to me. > > TCP fastopen would use 2 unused bits, not real extra cost here. > > This is persistent information after the connect(), while your tsval

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-21 Thread Eric Dumazet
On 10/21/19 11:49 AM, William Dauchy wrote: > I'm curious what would be the arguments compared to creating a new > getsockopt() to fetch this data? Reporting tsval/tsecr values were not well defined and seemed quite experimental to me. TCP fastopen would use 2 unused bits, not real extra co

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-21 Thread William Dauchy
Hello Jason, On Sat, Oct 19, 2019 at 11:10 AM Jason Baron wrote: > The TCPI_OPT_SYN_DATA bit as part of tcpi_options currently reports whether > or not data-in-SYN was ack'd on both the client and server side. We'd like > to gather more information on the client-side in the failure case in order

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-21 Thread Jason Baron
On 10/21/19 2:02 PM, Yuchung Cheng wrote: > Thanks for the patch. Detailed comments below > > On Fri, Oct 18, 2019 at 4:58 PM Neal Cardwell wrote: >> >> On Fri, Oct 18, 2019 at 3:03 PM Jason Baron wrote: >>> >>> The TCPI_OPT_SYN_DATA bit as part of tcpi_options currently reports whether >>> o

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-21 Thread Yuchung Cheng
Thanks for the patch. Detailed comments below On Fri, Oct 18, 2019 at 4:58 PM Neal Cardwell wrote: > > On Fri, Oct 18, 2019 at 3:03 PM Jason Baron wrote: > > > > The TCPI_OPT_SYN_DATA bit as part of tcpi_options currently reports whether > > or not data-in-SYN was ack'd on both the client and se

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-18 Thread Neal Cardwell
On Fri, Oct 18, 2019 at 3:03 PM Jason Baron wrote: > > The TCPI_OPT_SYN_DATA bit as part of tcpi_options currently reports whether > or not data-in-SYN was ack'd on both the client and server side. We'd like > to gather more information on the client-side in the failure case in order > to indicate

[net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-18 Thread Jason Baron
The TCPI_OPT_SYN_DATA bit as part of tcpi_options currently reports whether or not data-in-SYN was ack'd on both the client and server side. We'd like to gather more information on the client-side in the failure case in order to indicate the reason for the failure. This can be useful for not only d