RE: [EXT] Re: [V2 net-next] net: mvpp2: Add reserved port private flag configuration

2021-03-22 Thread Stefan Chulski
> > CM3 won't use this interface till ethtool priv flag was set, it can be done > > by > communication over CM3 SRAM memory. > > > > > How does CM3 know the status of the link? > > > > CM3 has access to MAC registers and can read port status bit. > > > > > How does CM3 set its > > > flow control d

Re: [EXT] Re: [V2 net-next] net: mvpp2: Add reserved port private flag configuration

2021-03-22 Thread Andrew Lunn
On Mon, Mar 22, 2021 at 03:59:43PM +, Stefan Chulski wrote: > > > > 2. CM3 code has very small footprint requirement, we cannot > > > implement the complete Serdes and PHY infrastructure that kernel > > > provides as part of CM3 application. Therefore I would like to > > > continue relying

RE: [EXT] Re: [V2 net-next] net: mvpp2: Add reserved port private flag configuration

2021-03-22 Thread Stefan Chulski
> > 2. CM3 code has very small footprint requirement, we cannot > > implement the complete Serdes and PHY infrastructure that kernel > > provides as part of CM3 application. Therefore I would like to > > continue relying on kernel configuration for that. > > How can that work? How does Linux

Re: [EXT] Re: [V2 net-next] net: mvpp2: Add reserved port private flag configuration

2021-03-18 Thread Andrew Lunn
> 2. CM3 code has very small footprint requirement, we cannot > implement the complete Serdes and PHY infrastructure that kernel > provides as part of CM3 application. Therefore I would like to > continue relying on kernel configuration for that. How can that work? How does Linux know when CM3 has

RE: [EXT] Re: [V2 net-next] net: mvpp2: Add reserved port private flag configuration

2021-03-16 Thread Stefan Chulski
> I really, really hope that someone has thought this through: > > Packet Processor I/O Interface (PPIO) > >The MUSDK PPIO driver provides low-level network interface API for >User-Space network drivers/applications. The PPIO infrastrcuture maps >Marvell's Packet Processor (PPv2) co

Re: [EXT] Re: [V2 net-next] net: mvpp2: Add reserved port private flag configuration

2021-03-16 Thread Russell King - ARM Linux admin
On Tue, Mar 16, 2021 at 03:28:51PM +, Stefan Chulski wrote: > No XDP doesn't require this. One of the use cases of the port reservation > feature is the Marvell User Space SDK (MUSDK) which its latest code is > publicly available here: > https://github.com/MarvellEmbeddedProcessors/musdk-marv

RE: [EXT] Re: [V2 net-next] net: mvpp2: Add reserved port private flag configuration

2021-03-16 Thread Stefan Chulski
> Hi Stefan > > Thanks for the strings change. Looks a lot better. > > Now i took a look at the bigger picture. > > > According to Armada SoC architecture and design, all the PPv2 ports > > which are populated on the same communication processor silicon die > > (CP11x) share the same Classifier

Re: [V2 net-next] net: mvpp2: Add reserved port private flag configuration

2021-03-11 Thread Jakub Kicinski
On Thu, 11 Mar 2021 18:43:27 +0200 stef...@marvell.com wrote: > According to Armada SoC architecture and design, all the PPv2 ports > which are populated on the same communication processor silicon die > (CP11x) share the same Classifier and Parser engines. > > Armada is an embedded platform and t

Re: [V2 net-next] net: mvpp2: Add reserved port private flag configuration

2021-03-11 Thread Andrew Lunn
On Thu, Mar 11, 2021 at 06:43:27PM +0200, stef...@marvell.com wrote: > From: Stefan Chulski Hi Stefan Thanks for the strings change. Looks a lot better. Now i took a look at the bigger picture. > According to Armada SoC architecture and design, all the PPv2 ports > which are populated on the s

[V2 net-next] net: mvpp2: Add reserved port private flag configuration

2021-03-11 Thread stefanc
From: Stefan Chulski According to Armada SoC architecture and design, all the PPv2 ports which are populated on the same communication processor silicon die (CP11x) share the same Classifier and Parser engines. Armada is an embedded platform and therefore there is a need to reserve some of the P

RE: [EXT] Re: [net-next] net: mvpp2: Add reserved port private flag configuration

2021-03-11 Thread Stefan Chulski
> > From: Stefan Chulski > > > > According to Armada SoC architecture and design, all the PPv2 ports > > which are populated on the same communication processor silicon die > > (CP11x) share the same Classifier and Parser engines. > > > > Armada is an embedded platform and therefore there is a nee

Re: [net-next] net: mvpp2: Add reserved port private flag configuration

2021-03-10 Thread Russell King - ARM Linux admin
On Wed, Mar 10, 2021 at 11:42:09AM +0200, stef...@marvell.com wrote: > From: Stefan Chulski > > According to Armada SoC architecture and design, all the PPv2 ports > which are populated on the same communication processor silicon die > (CP11x) share the same Classifier and Parser engines. > > Ar

Re: [EXT] Re: [net-next] net: mvpp2: Add reserved port private flag configuration

2021-03-10 Thread Andrew Lunn
> Make it patch series? I can split it to 2/3 patches. I don't think that will be needed. The helpers should be pretty obvious. Andrew

RE: [EXT] Re: [net-next] net: mvpp2: Add reserved port private flag configuration

2021-03-10 Thread Stefan Chulski
> k...@kernel.org; li...@armlinux.org.uk; m...@semihalf.com; > rmk+ker...@armlinux.org.uk; aten...@kernel.org; rab...@solid-run.com > Subject: [EXT] Re: [net-next] net: mvpp2: Add reserved port private flag > configuration > > External Email > > --

Re: [net-next] net: mvpp2: Add reserved port private flag configuration

2021-03-10 Thread Andrew Lunn
> static void mvpp2_ethtool_get_strings(struct net_device *netdev, u32 sset, > u8 *data) > { > struct mvpp2_port *port = netdev_priv(netdev); > int i, q; > > - if (sset != ETH_SS_STATS) > - return; > + switch (sset) { > + c

[net-next] net: mvpp2: Add reserved port private flag configuration

2021-03-10 Thread stefanc
From: Stefan Chulski According to Armada SoC architecture and design, all the PPv2 ports which are populated on the same communication processor silicon die (CP11x) share the same Classifier and Parser engines. Armada is an embedded platform and therefore there is a need to reserve some of the P