Re: [net-next,v5,00/12] add flow_rule infrastructure

2018-12-13 Thread Michal Kubecek
On Thu, Dec 13, 2018 at 08:54:39PM +0100, Pablo Neira Ayuso wrote: > On Thu, Dec 13, 2018 at 11:23:15AM -0800, Jakub Kicinski wrote: > > I think having the drivers call the IR translation could be a good > > compromise instead of having flower always pass down converted flows. > > > > tc flower ->

Re: [net-next,v5,00/12] add flow_rule infrastructure

2018-12-13 Thread Pablo Neira Ayuso
On Thu, Dec 13, 2018 at 11:23:15AM -0800, Jakub Kicinski wrote: > On Thu, 13 Dec 2018 12:06:39 +0200, Or Gerlitz wrote: > > > Maybe having a side library that could take a ethtool/flower/nft flow > > > and return common IR representation of that flow would be less painful? > > > Drivers could then

Re: [net-next,v5,00/12] add flow_rule infrastructure

2018-12-13 Thread Jakub Kicinski
On Thu, 13 Dec 2018 12:06:39 +0200, Or Gerlitz wrote: > > Maybe having a side library that could take a ethtool/flower/nft flow > > and return common IR representation of that flow would be less painful? > > Drivers could then migrate at its own pace, for new functionality etc. > > Was that discuss

Re: [net-next,v5,00/12] add flow_rule infrastructure

2018-12-13 Thread Or Gerlitz
On Wed, Dec 12, 2018 at 12:17 AM Jakub Kicinski wrote: > > On Tue, 11 Dec 2018 22:59:47 +0200, Or Gerlitz wrote: > > To put it a bit more clearly, donno if my concerns are to the extent of > > being fundamental, but yesknow that they were not sufficiently addressed. > > > > TC is the leading kerne

Re: [net-next,v5,00/12] add flow_rule infrastructure

2018-12-11 Thread Jakub Kicinski
On Tue, 11 Dec 2018 22:59:47 +0200, Or Gerlitz wrote: > To put it a bit more clearly, donno if my concerns are to the extent of > being fundamental, but yesknow that they were not sufficiently addressed. > > TC is the leading kernel CA system for about 2.5 decades, so I am not > clear what we want

Re: [net-next,v5,00/12] add flow_rule infrastructure

2018-12-11 Thread Or Gerlitz
On Tue, Dec 11, 2018 at 9:15 PM David Miller wrote: > From: Florian Westphal > > Pablo Neira Ayuso wrote: > >> This is another iteration of the in-kernel intermediate representation > >> (IR) that allows to express ACL hardware offloads using one unified > >> representation from the driver side

Re: [net-next,v5,00/12] add flow_rule infrastructure

2018-12-11 Thread David Miller
From: Florian Westphal Date: Tue, 11 Dec 2018 16:35:19 +0100 > Pablo Neira Ayuso wrote: > > [ trimming CCs ] > >> This is another iteration of the in-kernel intermediate representation >> (IR) that allows to express ACL hardware offloads using one unified >> representation from the driver side

Re: [net-next,v5,00/12] add flow_rule infrastructure

2018-12-11 Thread Florian Westphal
Pablo Neira Ayuso wrote: [ trimming CCs ] > This is another iteration of the in-kernel intermediate representation > (IR) that allows to express ACL hardware offloads using one unified > representation from the driver side for the ethtool and the tc > frontends [1] [2] [3]. [..] This is marked