Re: [PATCH net-next v2 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-18 Thread Tal Gilboa
On 9/10/2018 10:22 PM, Florian Fainelli wrote: On 09/10/2018 02:14 AM, Jose Abreu wrote: This follows David Miller advice and tries to fix coalesce timer in multi-queue scenarios. We are now using per-queue coalesce values and per-queue TX timer. Coalesce timer default values was changed to 1m

Re: [net-next, v2, 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-12 Thread Jose Abreu
Hi Neil, On 12-09-2018 14:50, Neil Armstrong wrote: > Hi Jose, > > On 11/09/2018 10:17, Jose Abreu wrote: >> On 10-09-2018 19:15, Neil Armstrong wrote: >>> RX is still ok but now TX fails almost immediately... >>> >>> With 100ms report : >>> >>> $ iperf3 -c 192.168.1.47 -t 0 -p 5202 -R -i 0.1 >>>

Re: [PATCH net-next v2 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-12 Thread Jose Abreu
Hi Florian, Thanks for your input. On 10-09-2018 20:22, Florian Fainelli wrote: > On 09/10/2018 02:14 AM, Jose Abreu wrote: >> This follows David Miller advice and tries to fix coalesce timer in >> multi-queue scenarios. >> >> We are now using per-queue coalesce values and per-queue TX timer. >>

Re: [net-next, v2, 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-12 Thread Neil Armstrong
Hi Jose, On 11/09/2018 10:17, Jose Abreu wrote: > On 10-09-2018 19:15, Neil Armstrong wrote: >> >> RX is still ok but now TX fails almost immediately... >> >> With 100ms report : >> >> $ iperf3 -c 192.168.1.47 -t 0 -p 5202 -R -i 0.1 >> Connecting to host 192.168.1.47, port 5202 >> Reverse mode, re

Re: [net-next, v2, 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-11 Thread Jose Abreu
On 10-09-2018 19:15, Neil Armstrong wrote: > > RX is still ok but now TX fails almost immediately... > > With 100ms report : > > $ iperf3 -c 192.168.1.47 -t 0 -p 5202 -R -i 0.1 > Connecting to host 192.168.1.47, port 5202 > Reverse mode, remote host 192.168.1.47 is sending > [ 4] local 192.168.1.4

Re: [PATCH net-next v2 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-10 Thread Florian Fainelli
On 09/10/2018 02:14 AM, Jose Abreu wrote: > This follows David Miller advice and tries to fix coalesce timer in > multi-queue scenarios. > > We are now using per-queue coalesce values and per-queue TX timer. > > Coalesce timer default values was changed to 1ms and the coalesce frames > to 25. >

Re: [net-next, v2, 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-10 Thread Neil Armstrong
Hi Jose, On 10/09/2018 18:21, Jose Abreu wrote: > On 10-09-2018 16:49, Neil Armstrong wrote: >> Hi Jose, >> >> On 10/09/2018 16:44, Jose Abreu wrote: >>> On 10-09-2018 14:46, Neil Armstrong wrote: hi Jose, On 10/09/2018 14:55, Jose Abreu wrote: > On 10-09-2018 13:52, Jose Abreu

Re: [net-next, v2, 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-10 Thread Jose Abreu
On 10-09-2018 16:49, Neil Armstrong wrote: > Hi Jose, > > On 10/09/2018 16:44, Jose Abreu wrote: >> On 10-09-2018 14:46, Neil Armstrong wrote: >>> hi Jose, >>> >>> On 10/09/2018 14:55, Jose Abreu wrote: On 10-09-2018 13:52, Jose Abreu wrote: > Can you please try attached follow-up patch ?

Re: [net-next, v2, 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-10 Thread Neil Armstrong
Hi Jose, On 10/09/2018 16:44, Jose Abreu wrote: > On 10-09-2018 14:46, Neil Armstrong wrote: >> hi Jose, >> >> On 10/09/2018 14:55, Jose Abreu wrote: >>> On 10-09-2018 13:52, Jose Abreu wrote: Can you please try attached follow-up patch ? >>> Oh, please apply the whole series otherwise this

Re: [net-next, v2, 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-10 Thread Jose Abreu
On 10-09-2018 14:46, Neil Armstrong wrote: > hi Jose, > > On 10/09/2018 14:55, Jose Abreu wrote: >> On 10-09-2018 13:52, Jose Abreu wrote: >>> Can you please try attached follow-up patch ? >> Oh, please apply the whole series otherwise this will not apply >> cleanly. > Indeed, it helps! > > With t

Re: [net-next, v2, 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-10 Thread Neil Armstrong
hi Jose, On 10/09/2018 14:55, Jose Abreu wrote: > On 10-09-2018 13:52, Jose Abreu wrote: >> >> Can you please try attached follow-up patch ? > > Oh, please apply the whole series otherwise this will not apply > cleanly. Indeed, it helps! With the fixups, it fails later, around 15s instead of 3

Re: [net-next, v2, 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-10 Thread Jose Abreu
On 10-09-2018 13:52, Jose Abreu wrote: > > Can you please try attached follow-up patch ? Oh, please apply the whole series otherwise this will not apply cleanly. Thanks and Best Regards, Jose Miguel Abreu

Re: [net-next, v2, 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-10 Thread Jose Abreu
Hi Neil, On 10-09-2018 12:43, Neil Armstrong wrote: > Hi Jose, > > On 10/09/2018 11:14, Jose Abreu wrote: >> This follows David Miller advice and tries to fix coalesce timer in >> multi-queue scenarios. >> >> We are now using per-queue coalesce values and per-queue TX timer. >> >> Coalesce timer d

Re: [net-next, v2, 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-10 Thread Neil Armstrong
Hi Jose, On 10/09/2018 11:14, Jose Abreu wrote: > This follows David Miller advice and tries to fix coalesce timer in > multi-queue scenarios. > > We are now using per-queue coalesce values and per-queue TX timer. > > Coalesce timer default values was changed to 1ms and the coalesce frames > to

[PATCH net-next v2 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-10 Thread Jose Abreu
This follows David Miller advice and tries to fix coalesce timer in multi-queue scenarios. We are now using per-queue coalesce values and per-queue TX timer. Coalesce timer default values was changed to 1ms and the coalesce frames to 25. Tested in B2B setup between XGMAC2 and GMAC5. Signed-off-