Re: [net] net: feature check mandating HW_CSUM is wrong

2021-01-15 Thread Alexander Duyck
On Thu, Jan 14, 2021 at 9:39 PM rohit maheshwari wrote: > > > On 13/01/21 10:37 PM, Tariq Toukan wrote: > > > > > > On 1/13/2021 5:35 AM, Alexander Duyck wrote: > >> On Tue, Jan 12, 2021 at 6:43 PM rohit maheshwari > >> wrote: > >>> > >>> > >>> On 07/01/21 12:47 AM, Jakub Kicinski wrote: > O

Re: [net] net: feature check mandating HW_CSUM is wrong

2021-01-14 Thread rohit maheshwari
On 13/01/21 10:37 PM, Tariq Toukan wrote: On 1/13/2021 5:35 AM, Alexander Duyck wrote: On Tue, Jan 12, 2021 at 6:43 PM rohit maheshwari wrote: On 07/01/21 12:47 AM, Jakub Kicinski wrote: On Wed,  6 Jan 2021 23:23:27 +0530 Rohit Maheshwari wrote: Mandating NETIF_F_HW_CSUM to enable TLS

Re: [net] net: feature check mandating HW_CSUM is wrong

2021-01-13 Thread Tariq Toukan
On 1/13/2021 5:35 AM, Alexander Duyck wrote: On Tue, Jan 12, 2021 at 6:43 PM rohit maheshwari wrote: On 07/01/21 12:47 AM, Jakub Kicinski wrote: On Wed, 6 Jan 2021 23:23:27 +0530 Rohit Maheshwari wrote: Mandating NETIF_F_HW_CSUM to enable TLS offload feature is wrong. And it broke tls o

Re: [net] net: feature check mandating HW_CSUM is wrong

2021-01-12 Thread Alexander Duyck
On Tue, Jan 12, 2021 at 6:43 PM rohit maheshwari wrote: > > > On 07/01/21 12:47 AM, Jakub Kicinski wrote: > > On Wed, 6 Jan 2021 23:23:27 +0530 Rohit Maheshwari wrote: > >> Mandating NETIF_F_HW_CSUM to enable TLS offload feature is wrong. > >> And it broke tls offload feature for the drivers, whi

Re: [net] net: feature check mandating HW_CSUM is wrong

2021-01-12 Thread Jakub Kicinski
On Wed, 13 Jan 2021 02:47:51 +0530 rohit maheshwari wrote: > On 07/01/21 12:47 AM, Jakub Kicinski wrote: > > On Wed, 6 Jan 2021 23:23:27 +0530 Rohit Maheshwari wrote: > >> Mandating NETIF_F_HW_CSUM to enable TLS offload feature is wrong. > >> And it broke tls offload feature for the drivers, whi

Re: [net] net: feature check mandating HW_CSUM is wrong

2021-01-12 Thread rohit maheshwari
On 07/01/21 12:47 AM, Jakub Kicinski wrote: On Wed, 6 Jan 2021 23:23:27 +0530 Rohit Maheshwari wrote: Mandating NETIF_F_HW_CSUM to enable TLS offload feature is wrong. And it broke tls offload feature for the drivers, which are still using NETIF_F_IP_CSUM or NETIF_F_IPV6_CSUM. We should use N

Re: [net] net: feature check mandating HW_CSUM is wrong

2021-01-06 Thread Jakub Kicinski
On Wed, 6 Jan 2021 23:23:27 +0530 Rohit Maheshwari wrote: > Mandating NETIF_F_HW_CSUM to enable TLS offload feature is wrong. > And it broke tls offload feature for the drivers, which are still > using NETIF_F_IP_CSUM or NETIF_F_IPV6_CSUM. We should use > NETIF_F_CSUM_MASK instead. > > Fixes: ae0

[net] net: feature check mandating HW_CSUM is wrong

2021-01-06 Thread Rohit Maheshwari
Mandating NETIF_F_HW_CSUM to enable TLS offload feature is wrong. And it broke tls offload feature for the drivers, which are still using NETIF_F_IP_CSUM or NETIF_F_IPV6_CSUM. We should use NETIF_F_CSUM_MASK instead. Fixes: ae0b04b238e2 ("net: Disable NETIF_F_HW_TLS_TX when HW_CSUM is disabled") S