Reply: [net] bonding: use return instead of goto

2016-02-06 Thread 张胜举
> On Fri, Feb 05, 2016 at 09:42:24AM +0800, 张胜举 wrote: > > > On Wed, Feb 03, 2016 at 06:15:22AM +, Zhang Shengju wrote: > > > > Replace 'goto' with 'return' to remove unnecessary check at label: > > > > err_undo_flags. > > > > > > I think you're going to have to explain how you came to the > >

Re: Reply: [net] bonding: use return instead of goto

2016-02-05 Thread Jarod Wilson
On Fri, Feb 05, 2016 at 09:42:24AM +0800, 张胜举 wrote: > > On Wed, Feb 03, 2016 at 06:15:22AM +, Zhang Shengju wrote: > > > Replace 'goto' with 'return' to remove unnecessary check at label: > > > err_undo_flags. > > > > I think you're going to have to explain how you came to the conclusion > >

Reply: [net] bonding: use return instead of goto

2016-02-04 Thread 张胜举
> On Wed, Feb 03, 2016 at 06:15:22AM +, Zhang Shengju wrote: > > Replace 'goto' with 'return' to remove unnecessary check at label: > > err_undo_flags. > > I think you're going to have to explain how you came to the conclusion that > the check isn't necessary. > > -- > Jarod Wilson > ja...@re

Re: [net] bonding: use return instead of goto

2016-02-04 Thread Jarod Wilson
On Wed, Feb 03, 2016 at 06:15:22AM +, Zhang Shengju wrote: > Replace 'goto' with 'return' to remove unnecessary check at label: > err_undo_flags. I think you're going to have to explain how you came to the conclusion that the check isn't necessary. -- Jarod Wilson ja...@redhat.com

[net] bonding: use return instead of goto

2016-02-02 Thread Zhang Shengju
Replace 'goto' with 'return' to remove unnecessary check at label: err_undo_flags. Signed-off-by: Zhang Shengju --- drivers/net/bonding/bond_main.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index