Re: [linux-usb-devel] [PATCH 2/2] usbnet: use MII hooks only if CONFIG_MII is enabled

2006-11-02 Thread David Brownell
On Tuesday 31 October 2006 5:23 pm, Adrian Bunk wrote: > select MII if USB_NET_AX8817X!=n || USB_NET_MCS7830!=n Thing is, I'm seeing that get morphed inside Kconfig to "select MII" in some cases ... the "if x != n" gets ignored, MII can't be deselected. That looks to me like a Kconfig de

Re: [linux-usb-devel] [PATCH 2/2] usbnet: use MII hooks only if CONFIG_MII is enabled

2006-10-31 Thread Adrian Bunk
On Tue, Oct 31, 2006 at 11:36:52AM -0800, David Brownell wrote: > > > > ... > > > depends on MII if MII != n > > > > > > except that Kconfig doesn't comprehend conditionals like that. > > > > You can express this in Kconfig: > > depends MII || MII=n > > Except that: > >

Re: [linux-usb-devel] [PATCH 2/2] usbnet: use MII hooks only if CONFIG_MII is enabled

2006-10-31 Thread David Brownell
> > ... > > depends on MII if MII != n > > > > except that Kconfig doesn't comprehend conditionals like that. > > You can express this in Kconfig: > depends MII || MII=n Except that: Warning! Found recursive dependency: USB_USBNET USB_NET_AX8817X MII USB_USBNET I

Re: [linux-usb-devel] [PATCH 2/2] usbnet: use MII hooks only if CONFIG_MII is enabled

2006-10-31 Thread David Brownell
> > +#if defined(CONFIG_MII) || defined(CONFIG_MII_MODULE) > > +#define HAVE_MII > >... > > This seems to cause a CONFIG_USB_USBNET=y, CONFIG_MII=m breakage > (as already described earlier in this thread)? Well, "alluded to" not described. Fixable by the equivalent of config USB_USBNET

Re: [linux-usb-devel] [PATCH 2/2] usbnet: use MII hooks only if CONFIG_MII is enabled

2006-10-31 Thread Adrian Bunk
On Tue, Oct 31, 2006 at 10:40:15AM -0700, David Brownell wrote: > > > > +#if defined(CONFIG_MII) || defined(CONFIG_MII_MODULE) > > > +#define HAVE_MII > > >... > > > > This seems to cause a CONFIG_USB_USBNET=y, CONFIG_MII=m breakage > > (as already described earlier in this thread)? > > Well, "a