Re: [iproute2 net-next 1/8] lib bpf: Add support for BPF_PROG_ATTACH and BPF_PROG_DETACH

2016-12-12 Thread Daniel Borkmann
On 12/12/2016 01:53 AM, David Ahern wrote: Signed-off-by: David Ahern Acked-by: Daniel Borkmann

[iproute2 net-next 1/8] lib bpf: Add support for BPF_PROG_ATTACH and BPF_PROG_DETACH

2016-12-11 Thread David Ahern
Signed-off-by: David Ahern --- include/bpf_util.h | 3 +++ lib/bpf.c | 21 + 2 files changed, 24 insertions(+) diff --git a/include/bpf_util.h b/include/bpf_util.h index 05baeecda57f..b038379684a8 100644 --- a/include/bpf_util.h +++ b/include/bpf_util.h @@ -75,6 +75

Re: [iproute2 net-next 1/8] lib bpf: Add support for BPF_PROG_ATTACH and BPF_PROG_DETACH

2016-12-10 Thread Daniel Borkmann
On 12/10/2016 11:15 PM, David Ahern wrote: On 12/10/16 2:21 PM, Daniel Borkmann wrote: Please name it bpf_prog_create() then, it would be consistent to bpf_map_create() and shorter as well. Sorry, lack of coffee, scratch that. Can't the current bpf_prog_attach() stay as is, and you name the

Re: [iproute2 net-next 1/8] lib bpf: Add support for BPF_PROG_ATTACH and BPF_PROG_DETACH

2016-12-10 Thread David Ahern
On 12/10/16 2:21 PM, Daniel Borkmann wrote: >> >> Please name it bpf_prog_create() then, it would be consistent to >> bpf_map_create() and shorter as well. > > Sorry, lack of coffee, scratch that. > > Can't the current bpf_prog_attach() stay as is, and you name the above new > functions bpf_prog_

Re: [iproute2 net-next 1/8] lib bpf: Add support for BPF_PROG_ATTACH and BPF_PROG_DETACH

2016-12-10 Thread Daniel Borkmann
On 12/10/2016 10:16 PM, Daniel Borkmann wrote: On 12/10/2016 09:32 PM, David Ahern wrote: For consistency with other bpf commands, the functions are named bpf_prog_attach and bpf_prog_detach. The existing bpf_prog_attach is renamed to bpf_prog_load_and_report since it calls bpf_prog_load and bpf

Re: [iproute2 net-next 1/8] lib bpf: Add support for BPF_PROG_ATTACH and BPF_PROG_DETACH

2016-12-10 Thread Daniel Borkmann
On 12/10/2016 09:32 PM, David Ahern wrote: For consistency with other bpf commands, the functions are named bpf_prog_attach and bpf_prog_detach. The existing bpf_prog_attach is renamed to bpf_prog_load_and_report since it calls bpf_prog_load and bpf_prog_report. Signed-off-by: David Ahern ---

[iproute2 net-next 1/8] lib bpf: Add support for BPF_PROG_ATTACH and BPF_PROG_DETACH

2016-12-10 Thread David Ahern
For consistency with other bpf commands, the functions are named bpf_prog_attach and bpf_prog_detach. The existing bpf_prog_attach is renamed to bpf_prog_load_and_report since it calls bpf_prog_load and bpf_prog_report. Signed-off-by: David Ahern --- include/bpf_util.h | 3 +++ lib/bpf.c

[iproute2 net-next 1/8] lib bpf: Add support for BPF_PROG_ATTACH and BPF_PROG_DETACH

2016-12-10 Thread David Ahern
For consistency with other bpf commands, the functions are named bpf_prog_attach and bpf_prog_detach. The existing bpf_prog_attach is renamed to bpf_prog_load_and_report since it calls bpf_prog_load and bpf_prog_report. Signed-off-by: David Ahern --- include/bpf_util.h | 3 +++ lib/bpf.c