Re: [iproute2-next v2 5/5] devlink: support setting the overwrite mask

2020-08-04 Thread Jacob Keller
On 8/3/2020 4:54 PM, David Ahern wrote: > On 8/3/20 5:30 PM, Jacob Keller wrote: >> >> Slightly unrelated: but the recent change to using a bitfield32 results >> in a "GENMASK is undefined".. I'm not sure what the proper way to fix >> this is, since we'd like to still use GENMASK to define the s

Re: [iproute2-next v2 5/5] devlink: support setting the overwrite mask

2020-08-03 Thread David Ahern
On 8/3/20 5:30 PM, Jacob Keller wrote: > > Slightly unrelated: but the recent change to using a bitfield32 results > in a "GENMASK is undefined".. I'm not sure what the proper way to fix > this is, since we'd like to still use GENMASK to define the supported > bitfields. I guess we need to pull in

Re: [iproute2-next v2 5/5] devlink: support setting the overwrite mask

2020-08-03 Thread Jacob Keller
On 8/3/2020 8:53 AM, David Ahern wrote: > On 7/31/20 6:21 PM, Jacob Keller wrote: >> Add support for specifying the overwrite sections to allow in the flash >> update command. This is done by adding a new "overwrite" option which >> can take either "settings" or "identifiers" passing the overwri

Re: [iproute2-next v2 5/5] devlink: support setting the overwrite mask

2020-08-03 Thread Jacob Keller
On 8/3/2020 2:20 PM, David Ahern wrote: > On 8/3/20 10:56 AM, Jacob Keller wrote: >> Sorry for the confusion here. I sent both the iproute2 and net-next >> changes to implement it in the kernel. > > please re-send the iproute2 patch; I already marked it in patchworks. I > get sending the patche

Re: [iproute2-next v2 5/5] devlink: support setting the overwrite mask

2020-08-03 Thread David Ahern
On 8/3/20 10:56 AM, Jacob Keller wrote: > Sorry for the confusion here. I sent both the iproute2 and net-next > changes to implement it in the kernel. please re-send the iproute2 patch; I already marked it in patchworks. I get sending the patches in 1 go, but kernel and iproute2 patch numbering sh

Re: [iproute2-next v2 5/5] devlink: support setting the overwrite mask

2020-08-03 Thread Jacob Keller
On 8/3/2020 8:53 AM, David Ahern wrote: > On 7/31/20 6:21 PM, Jacob Keller wrote: >> Add support for specifying the overwrite sections to allow in the flash >> update command. This is done by adding a new "overwrite" option which >> can take either "settings" or "identifiers" passing the overwri

Re: [iproute2-next v2 5/5] devlink: support setting the overwrite mask

2020-08-03 Thread Jiri Pirko
Mon, Aug 03, 2020 at 05:53:16PM CEST, dsah...@gmail.com wrote: >On 7/31/20 6:21 PM, Jacob Keller wrote: >> Add support for specifying the overwrite sections to allow in the flash >> update command. This is done by adding a new "overwrite" option which >> can take either "settings" or "identifiers"

Re: [iproute2-next v2 5/5] devlink: support setting the overwrite mask

2020-08-03 Thread David Ahern
On 7/31/20 6:21 PM, Jacob Keller wrote: > Add support for specifying the overwrite sections to allow in the flash > update command. This is done by adding a new "overwrite" option which > can take either "settings" or "identifiers" passing the overwrite mode > multiple times will combine the fields

[iproute2-next v2 5/5] devlink: support setting the overwrite mask

2020-07-31 Thread Jacob Keller
Add support for specifying the overwrite sections to allow in the flash update command. This is done by adding a new "overwrite" option which can take either "settings" or "identifiers" passing the overwrite mode multiple times will combine the fields using bitwise-OR. Signed-off-by: Jacob Keller