Re: [iproute PATCH v2 2/7] Use C99 style initializers everywhere

2016-06-22 Thread Jakub Sitnicki
On Wed, Jun 22, 2016 at 11:29 AM CEST, Phil Sutter wrote: > On Wed, Jun 22, 2016 at 11:12:14AM +0200, Jakub Sitnicki wrote: >> On Tue, Jun 21, 2016 at 06:18 PM CEST, Phil Sutter wrote: >> > This big patch was compiled by vimgrepping for memset calls and changing >> > to C99 initializer if applica

Re: [iproute PATCH v2 2/7] Use C99 style initializers everywhere

2016-06-22 Thread Phil Sutter
Hi Jakub, On Wed, Jun 22, 2016 at 11:12:14AM +0200, Jakub Sitnicki wrote: > On Tue, Jun 21, 2016 at 06:18 PM CEST, Phil Sutter wrote: > > This big patch was compiled by vimgrepping for memset calls and changing > > to C99 initializer if applicable. One notable exception is the > > initialization

Re: [iproute PATCH v2 2/7] Use C99 style initializers everywhere

2016-06-22 Thread Jakub Sitnicki
Hi Phil, On Tue, Jun 21, 2016 at 06:18 PM CEST, Phil Sutter wrote: > This big patch was compiled by vimgrepping for memset calls and changing > to C99 initializer if applicable. One notable exception is the > initialization of union bpf_attr in tc/tc_bpf.c: changing it would break > for older gcc

Re: [iproute PATCH v2 2/7] Use C99 style initializers everywhere

2016-06-21 Thread David Ahern
On 6/21/16 11:03 AM, Phil Sutter wrote: I downloaded CentOS 5 and 6. iproute2 fails to compile on CentOS 5.11; ip command builds on 6.8 but with a flurry of redefinition errors (BUILD_BUG_ON), but fails at tc. What's the exact error message please? Maybe some incompatibility in kernel headers?

Re: [iproute PATCH v2 2/7] Use C99 style initializers everywhere

2016-06-21 Thread Stephen Hemminger
On Tue, 21 Jun 2016 19:17:31 +0200 Phil Sutter wrote: > On Tue, Jun 21, 2016 at 11:13:11AM -0600, David Ahern wrote: > > On 6/21/16 11:03 AM, Phil Sutter wrote: > > >> I downloaded CentOS 5 and 6. iproute2 fails to compile on CentOS 5.11; > > >> ip command builds on 6.8 but with a flurry of redef

Re: [iproute PATCH v2 2/7] Use C99 style initializers everywhere

2016-06-21 Thread Phil Sutter
On Tue, Jun 21, 2016 at 11:13:11AM -0600, David Ahern wrote: > On 6/21/16 11:03 AM, Phil Sutter wrote: > >> I downloaded CentOS 5 and 6. iproute2 fails to compile on CentOS 5.11; > >> ip command builds on 6.8 but with a flurry of redefinition errors > >> (BUILD_BUG_ON), but fails at tc. > > > > Wha

Re: [iproute PATCH v2 2/7] Use C99 style initializers everywhere

2016-06-21 Thread Phil Sutter
On Tue, Jun 21, 2016 at 10:24:37AM -0600, David Ahern wrote: > On 6/21/16 10:18 AM, Phil Sutter wrote: > > This big patch was compiled by vimgrepping for memset calls and changing > > to C99 initializer if applicable. One notable exception is the > > initialization of union bpf_attr in tc/tc_bpf.c:

[iproute PATCH v2 2/7] Use C99 style initializers everywhere

2016-06-21 Thread Phil Sutter
This big patch was compiled by vimgrepping for memset calls and changing to C99 initializer if applicable. One notable exception is the initialization of union bpf_attr in tc/tc_bpf.c: changing it would break for older gcc versions (at least <=3.4.6). Calls to memset for struct rtattr pointer fiel

Re: [iproute PATCH v2 2/7] Use C99 style initializers everywhere

2016-06-21 Thread David Ahern
On 6/21/16 10:18 AM, Phil Sutter wrote: This big patch was compiled by vimgrepping for memset calls and changing to C99 initializer if applicable. One notable exception is the initialization of union bpf_attr in tc/tc_bpf.c: changing it would break for older gcc versions (at least <=3.4.6). Call