Re: [iproute PATCH v2 1/7] devlink: No need for this self-assignment

2017-08-21 Thread Jiri Pirko
Fri, Aug 18, 2017 at 12:20:24PM CEST, p...@nwl.cc wrote: >On Thu, Aug 17, 2017 at 09:48:50PM +0200, Jiri Pirko wrote: >> Thu, Aug 17, 2017 at 07:09:25PM CEST, p...@nwl.cc wrote: >> >dl_argv_handle_both() will either assign to handle_bit or error out in >> >which case the variable is not used by the

Re: [iproute PATCH v2 1/7] devlink: No need for this self-assignment

2017-08-18 Thread Phil Sutter
On Thu, Aug 17, 2017 at 09:48:50PM +0200, Jiri Pirko wrote: > Thu, Aug 17, 2017 at 07:09:25PM CEST, p...@nwl.cc wrote: > >dl_argv_handle_both() will either assign to handle_bit or error out in > >which case the variable is not used by the caller. > > I'm pretty sure that I did this to silence the

Re: [iproute PATCH v2 1/7] devlink: No need for this self-assignment

2017-08-17 Thread Jiri Pirko
Thu, Aug 17, 2017 at 07:09:25PM CEST, p...@nwl.cc wrote: >dl_argv_handle_both() will either assign to handle_bit or error out in >which case the variable is not used by the caller. I'm pretty sure that I did this to silence the compiler. If the compiler bug is fixed now, good. Acked-by: Jiri Pirk

[iproute PATCH v2 1/7] devlink: No need for this self-assignment

2017-08-17 Thread Phil Sutter
dl_argv_handle_both() will either assign to handle_bit or error out in which case the variable is not used by the caller. Signed-off-by: Phil Sutter --- devlink/devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devlink/devlink.c b/devlink/devlink.c index f9bc16c350c40