Re: [iproute PATCH] man: tc-csum.8: Fix example

2017-01-30 Thread Guillaume Nault
On Sat, Jan 28, 2017 at 12:16:48PM +0100, Phil Sutter wrote: > On Fri, Jan 27, 2017 at 09:49:58PM +0100, Guillaume Nault wrote: > > On Fri, Jan 27, 2017 at 12:15:01PM +0100, Phil Sutter wrote: > > > +# tc filter add dev eth0 prio 1 protocol ip parent : \\ > > > u32 match ip src 192.168.1.100/

Re: [iproute PATCH] man: tc-csum.8: Fix example

2017-01-28 Thread Phil Sutter
On Fri, Jan 27, 2017 at 09:49:58PM +0100, Guillaume Nault wrote: > On Fri, Jan 27, 2017 at 12:15:01PM +0100, Phil Sutter wrote: > > +# tc filter add dev eth0 prio 1 protocol ip parent : \\ > > u32 match ip src 192.168.1.100/32 flowid :1 \\ > > - action pedit munge ip dst set 0x12345678 pi

Re: [iproute PATCH] man: tc-csum.8: Fix example

2017-01-27 Thread Guillaume Nault
On Fri, Jan 27, 2017 at 12:15:01PM +0100, Phil Sutter wrote: > +# tc filter add dev eth0 prio 1 protocol ip parent : \\ > u32 match ip src 192.168.1.100/32 flowid :1 \\ > - action pedit munge ip dst set 0x12345678 pipe \\ > + action pedit munge ip dst set 1.2.3.4 pipe \\ > Just n

Re: [iproute PATCH] man: tc-csum.8: Fix example

2017-01-27 Thread Jiri Pirko
Fri, Jan 27, 2017 at 12:15:01PM CET, p...@nwl.cc wrote: >This fixes two issues with the provided example: > >- Add missing 'dev' keyword to second command. >- Use a real IPv4 address instead of a bogus hex value since that will > be rejected by get_addr_ipv4(). > >Fixes: dbfb17a67f9c7 ("man: tc-cs

[iproute PATCH] man: tc-csum.8: Fix example

2017-01-27 Thread Phil Sutter
This fixes two issues with the provided example: - Add missing 'dev' keyword to second command. - Use a real IPv4 address instead of a bogus hex value since that will be rejected by get_addr_ipv4(). Fixes: dbfb17a67f9c7 ("man: tc-csum.8: Add an example") Reported-by: Davide Caratti Signed-off-