Re: [ethtool PATCH v4 00/11] add support for new ETHTOOL_xLINKSETTINGS ioctls

2016-03-13 Thread Ben Hutchings
On Sun, 2016-03-13 at 17:30 +, Ben Hutchings wrote: [...] > Patch 11: you need to answer my question about this. [This is about why/whether there should be a fallback from creating an AF_INET socket to issue SIOCETHTOOL on.] I looked a little further, and found: - The only address/protocol fa

Re: [ethtool PATCH v4 00/11] add support for new ETHTOOL_xLINKSETTINGS ioctls

2016-03-13 Thread Ben Hutchings
On Fri, 2016-03-11 at 09:58 -0800, David Decotigny wrote: > From: David Decotigny > > This adds support for the new ETHTOOL_xLINKSETTINGS ioctls. This also > fixes a few compilation warnings as well as a heap corruption bug. [...] Patches 1-7: applied, thanks. Patch 8: this breaks builds from t

[ethtool PATCH v4 00/11] add support for new ETHTOOL_xLINKSETTINGS ioctls

2016-03-11 Thread David Decotigny
From: David Decotigny This adds support for the new ETHTOOL_xLINKSETTINGS ioctls. This also fixes a few compilation warnings as well as a heap corruption bug. History: v4 review Ben Hutchings: using AF_UNIX instead of INET6 in the absence of v4 sockets use stdbool.h do_se

[ethtool PATCH v4 00/11] add support for new ETHTOOL_xLINKSETTINGS ioctls

2016-03-07 Thread David Decotigny
From: David Decotigny This adds support for the new ETHTOOL_xLINKSETTINGS ioctls. This also fixes a few compilation warnings as well as a heap corruption bug. History: v4 review Ben Hutchings: using AF_UNIX instead of INET6 in the absence of v4 sockets use stdbool.h do_se