Re: [drivers/net/bnx2.c] ADVERTISE_1000XPSE_ASYM

2008-01-31 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 30 Jan 2008 10:51:10 -0800 > [BNX2]: Fix ASYM PAUSE advertisement for remote PHY. > > We were checking for the ASYM_PAUSE bit for 1000Base-X twice instead > checking for both the 1000Base-X bit and the 10/100/1000Base-T bit. > The purpose of the

Re: [drivers/net/bnx2.c] ADVERTISE_1000XPSE_ASYM

2008-01-30 Thread Michael Chan
On Wed, 2008-01-30 at 15:07 +0100, Roel Kluin wrote: > In drivers/net/bnx2.c:1285: it reads in function bnx2_setup_remote_phy(): > > if (pause_adv & (ADVERTISE_1000XPSE_ASYM | ADVERTISE_1000XPSE_ASYM)) > > Note that the two are the same and this is therefore equivalent to > > if (pause_adv & ADV

[drivers/net/bnx2.c] ADVERTISE_1000XPSE_ASYM

2008-01-30 Thread Roel Kluin
In drivers/net/bnx2.c:1285: it reads in function bnx2_setup_remote_phy(): if (pause_adv & (ADVERTISE_1000XPSE_ASYM | ADVERTISE_1000XPSE_ASYM)) Note that the two are the same and this is therefore equivalent to if (pause_adv & ADVERTISE_1000XPSE_ASYM) This appears to be incorrect, was maybe '| A