Re: [bpf PATCH v2 0/6] bpf: sockmap/tls fixes

2019-07-09 Thread John Fastabend
Jakub Kicinski wrote: > On Tue, 9 Jul 2019 17:04:59 -0700, Jakub Kicinski wrote: > > On Tue, 09 Jul 2019 08:40:14 -0700, John Fastabend wrote: > > > Jakub Kicinski wrote: > > > > Looks like strparser is not done'd for offload? > > > > > > Right so if rx_conf != TLS_SW then the hardware needs

Re: [bpf PATCH v2 0/6] bpf: sockmap/tls fixes

2019-07-09 Thread Jakub Kicinski
On Tue, 9 Jul 2019 17:04:59 -0700, Jakub Kicinski wrote: > On Tue, 09 Jul 2019 08:40:14 -0700, John Fastabend wrote: > > Jakub Kicinski wrote: > > > Looks like strparser is not done'd for offload? > > > > Right so if rx_conf != TLS_SW then the hardware needs to do > > the strparser functiona

Re: [bpf PATCH v2 0/6] bpf: sockmap/tls fixes

2019-07-09 Thread Jakub Kicinski
On Tue, 09 Jul 2019 08:40:14 -0700, John Fastabend wrote: > Jakub Kicinski wrote: > > Looks like strparser is not done'd for offload? > > Right so if rx_conf != TLS_SW then the hardware needs to do > the strparser functionality. Can I just take a stab at fixing the HW part? Can I rebase this o

Re: [bpf PATCH v2 0/6] bpf: sockmap/tls fixes

2019-07-09 Thread John Fastabend
Jakub Kicinski wrote: > On Mon, 08 Jul 2019 19:13:29 +, John Fastabend wrote: > > Resolve a series of splats discovered by syzbot and an unhash > > TLS issue noted by Eric Dumazet. > > > > The main issues revolved around interaction between TLS and > > sockmap tear down. TLS and sockmap could

Re: [bpf PATCH v2 0/6] bpf: sockmap/tls fixes

2019-07-08 Thread Jakub Kicinski
On Mon, 08 Jul 2019 19:13:29 +, John Fastabend wrote: > Resolve a series of splats discovered by syzbot and an unhash > TLS issue noted by Eric Dumazet. > > The main issues revolved around interaction between TLS and > sockmap tear down. TLS and sockmap could both reset sk->prot > ops creating

[bpf PATCH v2 0/6] bpf: sockmap/tls fixes

2019-07-08 Thread John Fastabend
Resolve a series of splats discovered by syzbot and an unhash TLS issue noted by Eric Dumazet. The main issues revolved around interaction between TLS and sockmap tear down. TLS and sockmap could both reset sk->prot ops creating a condition where a close or unhash op could be called forever. A rar