Re: [bpf PATCH 2/2] bpf, sockmap: fix incorrect fwd_alloc accounting

2021-03-25 Thread John Fastabend
Cong Wang wrote: > On Wed, Mar 24, 2021 at 7:46 PM John Fastabend > wrote: > > > > Cong Wang wrote: > > > On Wed, Mar 24, 2021 at 2:00 PM John Fastabend > > > wrote: > > > > > > > > Incorrect accounting fwd_alloc can result in a warning when the socket > > > > is torn down, > > > > > > > > [...

Re: [bpf PATCH 2/2] bpf, sockmap: fix incorrect fwd_alloc accounting

2021-03-25 Thread Cong Wang
On Wed, Mar 24, 2021 at 7:46 PM John Fastabend wrote: > > Cong Wang wrote: > > On Wed, Mar 24, 2021 at 2:00 PM John Fastabend > > wrote: > > > > > > Incorrect accounting fwd_alloc can result in a warning when the socket > > > is torn down, > > > > > [...] > > > > To resolve lets only account for

Re: [bpf PATCH 2/2] bpf, sockmap: fix incorrect fwd_alloc accounting

2021-03-24 Thread John Fastabend
Cong Wang wrote: > On Wed, Mar 24, 2021 at 2:00 PM John Fastabend > wrote: > > > > Incorrect accounting fwd_alloc can result in a warning when the socket > > is torn down, > > [...] > > To resolve lets only account for sockets on the ingress queue that are > > still associated with the current

Re: [bpf PATCH 2/2] bpf, sockmap: fix incorrect fwd_alloc accounting

2021-03-24 Thread Cong Wang
On Wed, Mar 24, 2021 at 2:00 PM John Fastabend wrote: > > Incorrect accounting fwd_alloc can result in a warning when the socket > is torn down, > > [18455.319240] WARNING: CPU: 0 PID: 24075 at net/core/stream.c:208 > sk_stream_kill_queues+0x21f/0x230 > [...] > [18455.319543] Call Trace: > [1

[bpf PATCH 2/2] bpf, sockmap: fix incorrect fwd_alloc accounting

2021-03-24 Thread John Fastabend
Incorrect accounting fwd_alloc can result in a warning when the socket is torn down, [18455.319240] WARNING: CPU: 0 PID: 24075 at net/core/stream.c:208 sk_stream_kill_queues+0x21f/0x230 [...] [18455.319543] Call Trace: [18455.319556] inet_csk_destroy_sock+0xba/0x1f0 [18455.319577] tcp_rcv_