Re: [bpf PATCH] bpf: selftest fix for sockmap

2018-06-13 Thread John Fastabend
On 06/12/2018 05:31 PM, Daniel Borkmann wrote: > On 06/11/2018 08:47 PM, John Fastabend wrote: >> In selftest test_maps the sockmap test case attempts to add a socket >> in listening state to the sockmap. This is no longer a valid operation >> so it fails as expected. However, the test wrongly repo

Re: [bpf PATCH] bpf: selftest fix for sockmap

2018-06-12 Thread Daniel Borkmann
On 06/11/2018 08:47 PM, John Fastabend wrote: > In selftest test_maps the sockmap test case attempts to add a socket > in listening state to the sockmap. This is no longer a valid operation > so it fails as expected. However, the test wrongly reports this as an > error now. Fix the test to avoid ad

Re: [bpf PATCH] bpf: selftest fix for sockmap

2018-06-11 Thread Y Song
On Mon, Jun 11, 2018 at 11:47 AM, John Fastabend wrote: > In selftest test_maps the sockmap test case attempts to add a socket > in listening state to the sockmap. This is no longer a valid operation > so it fails as expected. However, the test wrongly reports this as an > error now. Fix the test

[bpf PATCH] bpf: selftest fix for sockmap

2018-06-11 Thread John Fastabend
In selftest test_maps the sockmap test case attempts to add a socket in listening state to the sockmap. This is no longer a valid operation so it fails as expected. However, the test wrongly reports this as an error now. Fix the test to avoid adding sockets in listening state. Fixes: 945ae430aa44