Re: [bpf-next PATCH 3/3] xdp: split code for map vs non-map redirect

2018-09-04 Thread Jesper Dangaard Brouer
On Tue, 4 Sep 2018 23:39:45 +0800 kbuild test robot wrote: > Hi Jesper, > > Thank you for the patch! Perhaps something to improve: Daniel is faster than kbuild test-robot, and have already pointed this out, and it should be fixed in V2. -- Best regards, Jesper Dangaard Brouer MSc.CS, Prin

Re: [bpf-next PATCH 3/3] xdp: split code for map vs non-map redirect

2018-09-04 Thread kbuild test robot
Hi Jesper, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Jesper-Dangaard-Brouer/XDP-micro-optimizations-for-redirect/20180903-121606 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf

Re: [bpf-next PATCH 3/3] xdp: split code for map vs non-map redirect

2018-08-31 Thread Daniel Borkmann
On 08/31/2018 05:26 PM, Jesper Dangaard Brouer wrote: > The compiler does an efficient job of inlining static C functions. > Perf top clearly shows that almost everything gets inlined into the > function call xdp_do_redirect. > > The function xdp_do_redirect end-up containing and interleaving the

[bpf-next PATCH 3/3] xdp: split code for map vs non-map redirect

2018-08-31 Thread Jesper Dangaard Brouer
The compiler does an efficient job of inlining static C functions. Perf top clearly shows that almost everything gets inlined into the function call xdp_do_redirect. The function xdp_do_redirect end-up containing and interleaving the map and non-map redirect code. This is sub-optimal, as it would