Re: [bpf-next PATCH 2/4] selftests/bpf: Drop python client/server in favor of threads

2020-10-29 Thread Alexander Duyck
On Thu, Oct 29, 2020 at 11:13 AM Martin KaFai Lau wrote: > > On Thu, Oct 29, 2020 at 09:58:15AM -0700, Alexander Duyck wrote: > [ ... ] > [...] > > > > > Also, when looking closer at BPF_SOCK_OPS_STATE_CB in test_tcpbpf_kern.c, > > > it seems the map value "gp" is slapped together across multipl

Re: [bpf-next PATCH 2/4] selftests/bpf: Drop python client/server in favor of threads

2020-10-29 Thread Martin KaFai Lau
On Thu, Oct 29, 2020 at 09:58:15AM -0700, Alexander Duyck wrote: [ ... ] > > > @@ -43,7 +94,9 @@ int verify_result(const struct tcpbpf_globals *result) > > > EXPECT_EQ(0x80, result->bad_cb_test_rv, PRIu32); > > > EXPECT_EQ(0, result->good_cb_test_rv, PRIu32); > > > EXPECT_EQ(1, r

Re: [bpf-next PATCH 2/4] selftests/bpf: Drop python client/server in favor of threads

2020-10-29 Thread Alexander Duyck
On Wed, Oct 28, 2020 at 6:51 PM Martin KaFai Lau wrote: > > On Tue, Oct 27, 2020 at 06:47:13PM -0700, Alexander Duyck wrote: > > From: Alexander Duyck > > > > Drop the tcp_client/server.py files in favor of using a client and server > > thread within the test case. Specifically we spawn a new thr

Re: [bpf-next PATCH 2/4] selftests/bpf: Drop python client/server in favor of threads

2020-10-28 Thread Martin KaFai Lau
On Tue, Oct 27, 2020 at 06:47:13PM -0700, Alexander Duyck wrote: > From: Alexander Duyck > > Drop the tcp_client/server.py files in favor of using a client and server > thread within the test case. Specifically we spawn a new thread to play the > role of the server, and the main testing thread pl

[bpf-next PATCH 2/4] selftests/bpf: Drop python client/server in favor of threads

2020-10-28 Thread Alexander Duyck
From: Alexander Duyck Drop the tcp_client/server.py files in favor of using a client and server thread within the test case. Specifically we spawn a new thread to play the role of the server, and the main testing thread plays the role of client. Doing this we are able to reduce overhead since we