Re: [bpf-next PATCH 1/4] bpf: verifier track null pointer branch_taken with JNE and JEQ

2020-05-18 Thread John Fastabend
Andrii Nakryiko wrote: > On Mon, May 18, 2020 at 1:05 PM John Fastabend > wrote: > > > > Current verifier when considering which branch may be taken on a > > conditional test with pointer returns -1 meaning either branch may > > be taken. But, we track if pointers can be NULL by using dedicated >

Re: [bpf-next PATCH 1/4] bpf: verifier track null pointer branch_taken with JNE and JEQ

2020-05-18 Thread Andrii Nakryiko
On Mon, May 18, 2020 at 1:05 PM John Fastabend wrote: > > Current verifier when considering which branch may be taken on a > conditional test with pointer returns -1 meaning either branch may > be taken. But, we track if pointers can be NULL by using dedicated > types for valid pointers (pointers

RE: [bpf-next PATCH 1/4] bpf: verifier track null pointer branch_taken with JNE and JEQ

2020-05-18 Thread John Fastabend
John Fastabend wrote: > Current verifier when considering which branch may be taken on a > conditional test with pointer returns -1 meaning either branch may > be taken. But, we track if pointers can be NULL by using dedicated > types for valid pointers (pointers that can not be NULL). For example,

[bpf-next PATCH 1/4] bpf: verifier track null pointer branch_taken with JNE and JEQ

2020-05-18 Thread John Fastabend
Current verifier when considering which branch may be taken on a conditional test with pointer returns -1 meaning either branch may be taken. But, we track if pointers can be NULL by using dedicated types for valid pointers (pointers that can not be NULL). For example, we have PTR_TO_SOCK and PTR_T