Re: [bpf-next PATCH 1/3] net: fix generic XDP to handle if eth header was mangled

2018-10-04 Thread Song Liu
Hi Jesper, On Wed, Oct 3, 2018 at 7:04 AM Jesper Dangaard Brouer wrote: > > On Tue, 25 Sep 2018 22:36:39 -0700 > Song Liu wrote: > > > On Tue, Sep 25, 2018 at 7:26 AM Jesper Dangaard Brouer > > wrote: > > > > > > XDP can modify (and resize) the Ethernet header in the packet. > > > > > > There i

Re: [bpf-next PATCH 1/3] net: fix generic XDP to handle if eth header was mangled

2018-10-03 Thread Jesper Dangaard Brouer
On Tue, 25 Sep 2018 22:36:39 -0700 Song Liu wrote: > On Tue, Sep 25, 2018 at 7:26 AM Jesper Dangaard Brouer > wrote: > > > > XDP can modify (and resize) the Ethernet header in the packet. > > > > There is a bug in generic-XDP, because skb->protocol and skb->pkt_type > > are setup before reaching

Re: [bpf-next PATCH 1/3] net: fix generic XDP to handle if eth header was mangled

2018-10-01 Thread Daniel Borkmann
[ ping to Jesper wrt feedback ] On 09/26/2018 07:36 AM, Song Liu wrote: > On Tue, Sep 25, 2018 at 7:26 AM Jesper Dangaard Brouer > wrote: >> >> XDP can modify (and resize) the Ethernet header in the packet. >> >> There is a bug in generic-XDP, because skb->protocol and skb->pkt_type >> are setup

Re: [bpf-next PATCH 1/3] net: fix generic XDP to handle if eth header was mangled

2018-09-25 Thread Song Liu
On Tue, Sep 25, 2018 at 7:26 AM Jesper Dangaard Brouer wrote: > > XDP can modify (and resize) the Ethernet header in the packet. > > There is a bug in generic-XDP, because skb->protocol and skb->pkt_type > are setup before reaching (netif_receive_)generic_xdp. > > This bug was hit when XDP were po

[bpf-next PATCH 1/3] net: fix generic XDP to handle if eth header was mangled

2018-09-25 Thread Jesper Dangaard Brouer
XDP can modify (and resize) the Ethernet header in the packet. There is a bug in generic-XDP, because skb->protocol and skb->pkt_type are setup before reaching (netif_receive_)generic_xdp. This bug was hit when XDP were popping VLAN headers (changing eth->h_proto), as skb->protocol still contains