Re: [bpf-next PATCH] bpf: libbpf, support older style kprobe load

2019-10-22 Thread Andrii Nakryiko
On Tue, Oct 22, 2019 at 12:20 AM Daniel Borkmann wrote: > > On Mon, Oct 21, 2019 at 10:07:59PM -0700, John Fastabend wrote: > > Andrii Nakryiko wrote: > > > On Sat, Oct 19, 2019 at 1:30 AM John Fastabend > > > wrote: > > > > > > > > Following ./Documentation/trace/kprobetrace.rst add support for

Re: [bpf-next PATCH] bpf: libbpf, support older style kprobe load

2019-10-22 Thread Andrii Nakryiko
On Mon, Oct 21, 2019 at 10:08 PM John Fastabend wrote: > > Andrii Nakryiko wrote: > > On Sat, Oct 19, 2019 at 1:30 AM John Fastabend > > wrote: > > > > > > Following ./Documentation/trace/kprobetrace.rst add support for loading > > > kprobes programs on older kernels. > > > > > > > My main conce

Re: [bpf-next PATCH] bpf: libbpf, support older style kprobe load

2019-10-22 Thread Daniel Borkmann
On Mon, Oct 21, 2019 at 10:07:59PM -0700, John Fastabend wrote: > Andrii Nakryiko wrote: > > On Sat, Oct 19, 2019 at 1:30 AM John Fastabend > > wrote: > > > > > > Following ./Documentation/trace/kprobetrace.rst add support for loading > > > kprobes programs on older kernels. > > > > My main conc

Re: [bpf-next PATCH] bpf: libbpf, support older style kprobe load

2019-10-21 Thread John Fastabend
Andrii Nakryiko wrote: > On Sat, Oct 19, 2019 at 1:30 AM John Fastabend > wrote: > > > > Following ./Documentation/trace/kprobetrace.rst add support for loading > > kprobes programs on older kernels. > > > > My main concern with this is that this code is born bit-rotten, > because selftests are

Re: [bpf-next PATCH] bpf: libbpf, support older style kprobe load

2019-10-21 Thread Andrii Nakryiko
On Sat, Oct 19, 2019 at 1:30 AM John Fastabend wrote: > > Following ./Documentation/trace/kprobetrace.rst add support for loading > kprobes programs on older kernels. > My main concern with this is that this code is born bit-rotten, because selftests are never testing the legacy code path. How di

Re: [bpf-next PATCH] bpf: libbpf, support older style kprobe load

2019-10-18 Thread Yonghong Song
On 10/18/19 3:01 PM, John Fastabend wrote: > Daniel Borkmann wrote: >> On Fri, Oct 18, 2019 at 07:54:26AM -0700, John Fastabend wrote: >>> Following ./Documentation/trace/kprobetrace.rst add support for loading >>> kprobes programs on older kernels. >>> >>> Signed-off-by: John Fastabend >>> ---

Re: [bpf-next PATCH] bpf: libbpf, support older style kprobe load

2019-10-18 Thread John Fastabend
Daniel Borkmann wrote: > On Fri, Oct 18, 2019 at 07:54:26AM -0700, John Fastabend wrote: > > Following ./Documentation/trace/kprobetrace.rst add support for loading > > kprobes programs on older kernels. > > > > Signed-off-by: John Fastabend > > --- > > tools/lib/bpf/libbpf.c | 81 > > +++

Re: [bpf-next PATCH] bpf: libbpf, support older style kprobe load

2019-10-18 Thread Daniel Borkmann
On Fri, Oct 18, 2019 at 07:54:26AM -0700, John Fastabend wrote: > Following ./Documentation/trace/kprobetrace.rst add support for loading > kprobes programs on older kernels. > > Signed-off-by: John Fastabend > --- > tools/lib/bpf/libbpf.c | 81 > +++---

[bpf-next PATCH] bpf: libbpf, support older style kprobe load

2019-10-18 Thread John Fastabend
Following ./Documentation/trace/kprobetrace.rst add support for loading kprobes programs on older kernels. Signed-off-by: John Fastabend --- tools/lib/bpf/libbpf.c | 81 +++- 1 file changed, 73 insertions(+), 8 deletions(-) diff --git a/tools/lib/bp