Re: [bpf-next PATCH] bpf: add comments to BPF ld/ldx sizes

2018-01-18 Thread Daniel Borkmann
On 01/17/2018 12:05 PM, Jesper Dangaard Brouer wrote: > Doc BPF ld/ldx size defines as comments in code, as it makes in > faster to lookup in a programming/review setting, than looking up > the sizes in Documentation/networking/filter.txt. > > Signed-off-by: Jesper Dangaard Brouer Applied to bpf

[bpf-next PATCH] bpf: add comments to BPF ld/ldx sizes

2018-01-17 Thread Jesper Dangaard Brouer
Doc BPF ld/ldx size defines as comments in code, as it makes in faster to lookup in a programming/review setting, than looking up the sizes in Documentation/networking/filter.txt. Signed-off-by: Jesper Dangaard Brouer --- include/uapi/linux/bpf.h|2 +- include/uapi/linux/bpf_common.h

Re: [RFC bpf-next PATCH] bpf: add comments to BPF ld/ldx sizes

2018-01-17 Thread Jesper Dangaard Brouer
On Wed, 17 Jan 2018 00:21:27 +0100 Daniel Borkmann wrote: > On 01/16/2018 12:31 PM, Jesper Dangaard Brouer wrote: > > Doc BPF ld/ldx size defines, as it help me understand the code in filter.c. > > > > Signed-off-by: Jesper Dangaard Brouer > > --- > > 0 files changed > > > > diff --git a/incl

Re: [RFC bpf-next PATCH] bpf: add comments to BPF ld/ldx sizes

2018-01-16 Thread Daniel Borkmann
On 01/16/2018 12:31 PM, Jesper Dangaard Brouer wrote: > Doc BPF ld/ldx size defines, as it help me understand the code in filter.c. > > Signed-off-by: Jesper Dangaard Brouer > --- > 0 files changed > > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h > index 395d261948de..4729d9

[RFC bpf-next PATCH] bpf: add comments to BPF ld/ldx sizes

2018-01-16 Thread Jesper Dangaard Brouer
Doc BPF ld/ldx size defines, as it help me understand the code in filter.c. Signed-off-by: Jesper Dangaard Brouer --- 0 files changed diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h index 395d261948de..4729d9a002d4 100644 --- a/include/uapi/linux/bpf.h +++ b/include/uapi/linux/