Re: [bpf-net PATCH v2] bpf: sockmap missing NULL psock check

2018-01-06 Thread Daniel Borkmann
On 01/05/2018 05:02 AM, John Fastabend wrote: > Add psock NULL check to handle a racing sock event that can get the > sk_callback_lock before this case but after xchg happens causing the > refcnt to hit zero and sock user data (psock) to be null and queued > for garbage collection. > > Also add a

[bpf-net PATCH v2] bpf: sockmap missing NULL psock check

2018-01-04 Thread John Fastabend
Add psock NULL check to handle a racing sock event that can get the sk_callback_lock before this case but after xchg happens causing the refcnt to hit zero and sock user data (psock) to be null and queued for garbage collection. Also add a comment in the code because this is a bit subtle and not o