On 15/6/07 13:21, "Michael Buesch" <[EMAIL PROTECTED]> wrote:
>> True in general, but not the cases I've seen in this patchset, where 'foo'
>> is a predicate.
>
> Ok, if foo is a variable containing an error code, it's
> better to return that error code. I assumed that foo is a
> variable cont
On Friday 15 June 2007 14:20:34 Keir Fraser wrote:
>
> On 15/6/07 13:11, "Michael Buesch" <[EMAIL PROTECTED]> wrote:
>
> >> No use of the following please:
> >> If (foo) return 1; else return 0;
> >> Is clearer as:
> >> Return foo;
> >
> > But it's not the same.
> > return !!foo;
> > would be th
On 15/6/07 13:11, "Michael Buesch" <[EMAIL PROTECTED]> wrote:
>> No use of the following please:
>> If (foo) return 1; else return 0;
>> Is clearer as:
>> Return foo;
>
> But it's not the same.
> return !!foo;
> would be the same. And yes, it does matter:
True in general, but not the cases I'
On Friday 15 June 2007 13:26:03 Keir Fraser wrote:
> On 15/6/07 11:46, "Kieran Mansley" <[EMAIL PROTECTED]> wrote:
>
> > This is a repost of some earlier patches to the xen-devel mailing list,
> > with a number of changes thanks to some useful suggestions from others.
>
> The coding style needs f
On 15/6/07 11:46, "Kieran Mansley" <[EMAIL PROTECTED]> wrote:
> This is a repost of some earlier patches to the xen-devel mailing list,
> with a number of changes thanks to some useful suggestions from others.
The coding style needs fixing in various ways.
Hard tabs need to be used, no spaces in
