Re: [Xen-devel] [PATCH] xen-netback: prefer xenbus_scanf() over xenbus_gather()

2016-07-07 Thread Jan Beulich
>>> On 07.07.16 at 11:55, wrote: > On 07/07/16 08:57, Jan Beulich wrote: >> --- 4.7-rc6-prefer-xenbus_scanf.orig/drivers/net/xen-netback/xenbus.c >> +++ 4.7-rc6-prefer-xenbus_scanf/drivers/net/xen-netback/xenbus.c >> @@ -842,16 +842,16 @@ static int connect_ctrl_ring(struct back >> unsigned i

Re: [Xen-devel] [PATCH] xen-netback: prefer xenbus_scanf() over xenbus_gather()

2016-07-07 Thread David Vrabel
On 07/07/16 08:57, Jan Beulich wrote: > ... for single items being collected: It is more typesafe (as the > compiler can check format string and to-be-written-to variable match) > and requires one less parameter to be passed. Do not split commit messages between the subject and the body in this wa