Re: [XFRM]: constify 'struct xfrm_type'

2008-01-30 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Thu, 24 Jan 2008 12:26:21 +0100 > Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> Applied, thanks Eric. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vg

Re: [XFRM]: constify 'struct xfrm_type'

2008-01-24 Thread Joe Perches
On Thu, 2008-01-24 at 20:24 +0100, Eric Dumazet wrote: > I still dont understand what *you* want to do. Mark the accesses as "* const" not "const *" -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://v

Re: [XFRM]: constify 'struct xfrm_type'

2008-01-24 Thread Eric Dumazet
Joe Perches a écrit : On Thu, 2008-01-24 at 19:23 +0100, Eric Dumazet wrote: Having const data is nice because moving them from .data to .rodata, but what would be practical gains to use a const pointer ??? const data is good, using pointers to const data is good. Yes, this is what is done.

Re: [XFRM]: constify 'struct xfrm_type'

2008-01-24 Thread Joe Perches
On Thu, 2008-01-24 at 19:23 +0100, Eric Dumazet wrote: > Having const data is nice because moving them from .data to .rodata, > but what would be practical gains to use a const pointer ??? const data is good, using pointers to const data is good. using const pointers to const data is good. using c

Re: [XFRM]: constify 'struct xfrm_type'

2008-01-24 Thread Eric Dumazet
Joe Perches a écrit : On Thu, 2008-01-24 at 12:26 +0100, Eric Dumazet wrote: - struct xfrm_type *type; + const struct xfrm_type *type; Perhaps const foo * const bar; for most or all of these conversions? Hum... Having const data is nice because moving them from .data to .rodata

Re: [XFRM]: constify 'struct xfrm_type'

2008-01-24 Thread Joe Perches
On Thu, 2008-01-24 at 12:26 +0100, Eric Dumazet wrote: > - struct xfrm_type *type; > + const struct xfrm_type *type; Perhaps const foo * const bar; for most or all of these conversions? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAI

[XFRM]: constify 'struct xfrm_type'

2008-01-24 Thread Eric Dumazet
Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> include/net/xfrm.h |8 net/ipv4/ah4.c |2 +- net/ipv4/esp4.c |2 +- net/ipv4/ipcomp.c |2 +- net/ipv4/xfrm4_tunnel.c |2 +- net/ipv6/ah6.c |2 +- net/ipv6/esp6.c |2 +-