From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Mon, 06 Mar 2006 14:20:06 +0100
> Sorry, thats just as broken as before. Better patch attached.
Applied, thanks Patrick.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo
jamal wrote:
> On Mon, 2006-06-03 at 15:01 +0100, Patrick McHardy wrote:
>
>>The rcu_dereference
>>doesn't cost anything except on alpha. We could reduce the overhead a
>>bit more by avoiding the rcu_read_lock/rcu_read_unlock, the code is
>>AFAICT only called from the xfrm output functions, which
On Mon, 2006-06-03 at 15:01 +0100, Patrick McHardy wrote:
>
> xfrm_user can be a module, so an ifdef won't help.
good point.
> The rcu_dereference
> doesn't cost anything except on alpha. We could reduce the overhead a
> bit more by avoiding the rcu_read_lock/rcu_read_unlock, the code is
> AFA
jamal wrote:
> On Mon, 2006-06-03 at 14:20 +0100, Patrick McHardy wrote:
>
>
>>[XFRM]: Fix aevent related crash
>>
>>When xfrm_user isn't loaded xfrm_nl is NULL, which makes IPsec crash because
>>xfrm_aevent_is_on passes the NULL pointer to netlink_has_list
On Mon, 2006-06-03 at 14:20 +0100, Patrick McHardy wrote:
> [XFRM]: Fix aevent related crash
>
> When xfrm_user isn't loaded xfrm_nl is NULL, which makes IPsec crash because
> xfrm_aevent_is_on passes the NULL pointer to netlink_has_listeners as socket.
For the above wouldn
t xfrm_user_exit(void)
> {
> xfrm_unregister_km(&netlink_mgr);
> + rcu_assign_pointer(xfrm_nl, NULL);
> + synchronize_rcu();
> sock_release(xfrm_nl->sk_socket);
> }
>
Sorry, thats just as broken as before. Better patch attached.
[XFRM]: Fix
Fix a regression in net-2.6.17 from the aevent patches.
[XFRM]: Fix aevent related crash
When xfrm_user isn't loaded xfrm_nl is NULL, which makes IPsec crash because
xfrm_aevent_is_on passes the NULL pointer to netlink_has_listeners as socket.
A second problem is that the xfrm_nl pointer i