Re: [UDP6]: Restore sk_filter optimisation

2007-11-01 Thread Mitsuru Chinen
On Wed, 31 Oct 2007 22:42:57 +0800 Herbert Xu <[EMAIL PROTECTED]> wrote: > On Wed, Oct 31, 2007 at 11:05:45PM +0900, Mitsuru Chinen wrote: > > > > > > 1. udp6InDatagrams is incremented instead of udpInErrors > > > > 2. In userland, recvfrom() replies an error with EAGAIN. > > > > recvfrom()

Re: [UDP6]: Restore sk_filter optimisation

2007-10-31 Thread Herbert Xu
On Wed, Oct 31, 2007 at 11:05:45PM +0900, Mitsuru Chinen wrote: > > > > 1. udp6InDatagrams is incremented instead of udpInErrors > > > 2. In userland, recvfrom() replies an error with EAGAIN. > > > recvfrom() wasn't aware of such a packet before. > > > > > > Are these changes intentional? >

Re: [UDP6]: Restore sk_filter optimisation

2007-10-31 Thread Mitsuru Chinen
On Mon, 29 Oct 2007 20:53:28 +0800 Herbert Xu <[EMAIL PROTECTED]> wrote: > On Mon, Oct 29, 2007 at 03:33:20PM +0900, Mitsuru Chinen wrote: > > Hello Herbert, > > > > Let me ask a question about this patch. > > After this patch was applied, 2 of the protocol stack behaviors were > > changed when i

Re: [UDP6]: Restore sk_filter optimisation

2007-10-29 Thread Herbert Xu
On Mon, Oct 29, 2007 at 03:33:20PM +0900, Mitsuru Chinen wrote: > Hello Herbert, > > Let me ask a question about this patch. > After this patch was applied, 2 of the protocol stack behaviors were > changed when it receives a UDP datagram with broken checksum: > > 1. udp6InDatagrams is incremente

Re: [UDP6]: Restore sk_filter optimisation

2007-10-28 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Mon, 29 Oct 2007 15:33:20 +0900), Mitsuru Chinen <[EMAIL PROTECTED]> says: > Hello Herbert, > > Let me ask a question about this patch. > After this patch was applied, 2 of the protocol stack behaviors were > changed when it receives a UDP datagram with broken

Re: [UDP6]: Restore sk_filter optimisation

2007-10-28 Thread Mitsuru Chinen
EAGAIN. recvfrom() wasn't aware of such a packet before. Are these changes intentional? Best Regards, Mitsuru Chinen <[EMAIL PROTECTED]> On Tue, 6 Mar 2007 12:20:10 +1100 Herbert Xu <[EMAIL PROTECTED]> wrote: > Hi Dave: > > [UDP6]: Restore sk_filter optimisa

Re: [UDP6]: Restore sk_filter optimisation

2007-03-06 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Tue, 6 Mar 2007 12:20:10 +1100 > Hi Dave: > > [UDP6]: Restore sk_filter optimisation > > This reverts the changeset > > [IPV6]: UDPv6 checksum. > > We always need to check UDPv6 checksum because it

[UDP6]: Restore sk_filter optimisation

2007-03-05 Thread Herbert Xu
Hi Dave: [UDP6]: Restore sk_filter optimisation This reverts the changeset [IPV6]: UDPv6 checksum. We always need to check UDPv6 checksum because it is mandatory. The sk_filter optimisation has nothing to do whether we verify the checksum. It simply postpones it to the point when the