Re: [TG3 1/8]: Save MSI state before suspend.

2007-02-13 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 13 Feb 2007 12:13:32 -0800 > [TG3]: Save MSI state before suspend. > > This fixes the following problem: > > http://bugzilla.kernel.org/show_bug.cgi?id=7969 > > The MSI state needs to be saved during suspend. PCI state saved > during tg3_init

Re: [TG3 1/8]: Save MSI state before suspend.

2007-02-13 Thread Michael Chan
On Tue, 2007-02-13 at 11:58 -0800, Stephen Hemminger wrote: > > I think you have to move the original pci_save_state call, otherwise > you will call pci_save_state twice and leak memory. pci_save_state > allocates memory to store MSI and other information. Look at > pci_save_pcie_state > etc. >

Re: [TG3 1/8]: Save MSI state before suspend.

2007-02-13 Thread Jeff Garzik
On Tue, Feb 13, 2007 at 11:58:25AM -0800, Stephen Hemminger wrote: > I think you have to move the original pci_save_state call, otherwise > you will call pci_save_state twice and leak memory. pci_save_state > allocates memory to store MSI and other information. Look at > pci_save_pcie_state > etc

Re: [TG3 1/8]: Save MSI state before suspend.

2007-02-13 Thread Stephen Hemminger
On Tue, 13 Feb 2007 12:13:32 -0800 "Michael Chan" <[EMAIL PROTECTED]> wrote: > [TG3]: Save MSI state before suspend. > > This fixes the following problem: > > http://bugzilla.kernel.org/show_bug.cgi?id=7969 > > The MSI state needs to be saved during suspend. PCI state saved > during tg3_init_o

Re: [TG3 1/8]: Save MSI state before suspend.

2007-02-13 Thread Michael Chan
On Tue, 2007-02-13 at 14:45 -0500, Jeff Garzik wrote: > > I'm curious if, after this patch is applied, all the pci_save_state() > calls are truly necessary? > The others are necessary to save/restore the memory enable bit in the PCI command register. This bit gets reset after chip reset. - To

Re: [TG3 1/8]: Save MSI state before suspend.

2007-02-13 Thread Jeff Garzik
On Tue, Feb 13, 2007 at 12:13:32PM -0800, Michael Chan wrote: > [TG3]: Save MSI state before suspend. > > This fixes the following problem: > > http://bugzilla.kernel.org/show_bug.cgi?id=7969 > > The MSI state needs to be saved during suspend. PCI state saved > during tg3_init_one() does not co

[TG3 1/8]: Save MSI state before suspend.

2007-02-13 Thread Michael Chan
[TG3]: Save MSI state before suspend. This fixes the following problem: http://bugzilla.kernel.org/show_bug.cgi?id=7969 The MSI state needs to be saved during suspend. PCI state saved during tg3_init_one() does not contain valid MSI state because MSI hasn't been enabled. Signed-off-by: Michael