Re: [TG3]: Workaround MSI bug on 5714/5780.

2007-09-14 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Fri, 07 Sep 2007 19:26:21 -0700 > [PCI]: Add MSI quirk for ServerWorks HT1000 PCIX bridge. > > This is the fix for the following problem: > > https://bugzilla.redhat.com/show_bug.cgi?id=227657 > > The bnx2 device 5706 complains about MSI not workin

Re: [TG3]: Workaround MSI bug on 5714/5780.

2007-09-08 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Fri, 07 Sep 2007 19:26:21 -0700 > David, I see that you have already done the revert in your 2.6.23 tree. I intend to revert that and only push the tg3 fix into 2.6.23 Earlier I had the idea to undo the quirk too, but that's something I decided was

Re: [TG3]: Workaround MSI bug on 5714/5780.

2007-09-07 Thread Michael Chan
On Thu, 2007-09-06 at 12:50 -0700, David Miller wrote: > From: "Michael Chan" <[EMAIL PROTECTED]> > Date: Thu, 06 Sep 2007 12:05:30 -0700 > > > The HT1000 bridge may very well have an MSI issue. I'm checking with > > ServerWorks and I will do some testing to confirm. If confirmed, we can > > dis

Re: [TG3]: Workaround MSI bug on 5714/5780.

2007-09-06 Thread Andy Gospodarek
On Thu, Sep 06, 2007 at 12:50:19PM -0700, David Miller wrote: > From: "Michael Chan" <[EMAIL PROTECTED]> > Date: Thu, 06 Sep 2007 12:05:30 -0700 > > > The HT1000 bridge may very well have an MSI issue. I'm checking with > > ServerWorks and I will do some testing to confirm. If confirmed, we can

Re: [TG3]: Workaround MSI bug on 5714/5780.

2007-09-06 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 06 Sep 2007 12:05:30 -0700 > The HT1000 bridge may very well have an MSI issue. I'm checking with > ServerWorks and I will do some testing to confirm. If confirmed, we can > disable MSI behind the HT1000 bridge instead of globally. The 5714 >

Re: [TG3]: Workaround MSI bug on 5714/5780.

2007-09-06 Thread Andy Gospodarek
On Thu, Sep 06, 2007 at 12:05:30PM -0700, Michael Chan wrote: > On Thu, 2007-09-06 at 11:41 -0400, Andy Gospodarek wrote: > > On Thu, Sep 06, 2007 at 07:34:23AM -0700, David Miller wrote: > > > From: Andy Gospodarek <[EMAIL PROTECTED]> > > > Date: Thu, 6 Sep 2007 09:45:16 -0400 > > > > > > > Is is

Re: [TG3]: Workaround MSI bug on 5714/5780.

2007-09-06 Thread Michael Chan
On Thu, 2007-09-06 at 11:41 -0400, Andy Gospodarek wrote: > On Thu, Sep 06, 2007 at 07:34:23AM -0700, David Miller wrote: > > From: Andy Gospodarek <[EMAIL PROTECTED]> > > Date: Thu, 6 Sep 2007 09:45:16 -0400 > > > > > Is is really necessary to get rid of the HT1000 patch? > > > > Yes, absolutely

Re: [TG3]: Workaround MSI bug on 5714/5780.

2007-09-06 Thread Andy Gospodarek
On Thu, Sep 06, 2007 at 07:34:23AM -0700, David Miller wrote: > From: Andy Gospodarek <[EMAIL PROTECTED]> > Date: Thu, 6 Sep 2007 09:45:16 -0400 > > > Is is really necessary to get rid of the HT1000 patch? > > Yes, absolutely and without a single doubt. > > > commit e3008dedff4bdc96a5f67224cd3d8

Re: [TG3]: Workaround MSI bug on 5714/5780.

2007-09-06 Thread Michael Chan
Andy Gospodarek wrote: > This patch was designed to address tg3 and bnx2 messages printed on > systems with HT1000 chips IIRC. Are we going back to those > messages on > bnx2 or is there a workaround in that driver needed too? > Andy, I've checked all the Broadcom chips including bnx2 chips, o

Re: [TG3]: Workaround MSI bug on 5714/5780.

2007-09-06 Thread Andy Gospodarek
On 9/6/07, David Miller <[EMAIL PROTECTED]> wrote: > From: Andy Gospodarek <[EMAIL PROTECTED]> > Date: Thu, 6 Sep 2007 09:45:16 -0400 > > > Is is really necessary to get rid of the HT1000 patch? > > Yes, absolutely and without a single doubt. > > > commit e3008dedff4bdc96a5f67224cd3d8d12237082a0 >

Re: [TG3]: Workaround MSI bug on 5714/5780.

2007-09-06 Thread David Miller
From: Andy Gospodarek <[EMAIL PROTECTED]> Date: Thu, 6 Sep 2007 09:45:16 -0400 > Is is really necessary to get rid of the HT1000 patch? Yes, absolutely and without a single doubt. > commit e3008dedff4bdc96a5f67224cd3d8d12237082a0 > Author: Andy Gospodarek <[EMAIL PROTECTED]> > Date: Thu May 10

Re: [TG3]: Workaround MSI bug on 5714/5780.

2007-09-06 Thread Andy Gospodarek
On Thu, Sep 06, 2007 at 04:02:35AM -0700, David Miller wrote: > From: "Michael Chan" <[EMAIL PROTECTED]> > Date: Wed, 05 Sep 2007 13:07:08 -0700 > > > [TG3]: Workaround MSI bug on 5714/5780. > > > > A hardware bug was revealed after a recent PCI MSI

Re: [TG3]: Workaround MSI bug on 5714/5780.

2007-09-06 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 05 Sep 2007 13:07:08 -0700 > [TG3]: Workaround MSI bug on 5714/5780. > > A hardware bug was revealed after a recent PCI MSI patch was made to > always disable legacy INTX when enabling MSI. The 5714/5780 chips >

Re: [TG3]: Workaround MSI bug on 5714/5780.

2007-09-05 Thread Andy Gospodarek
On 9/5/07, Michael Chan <[EMAIL PROTECTED]> wrote: > [TG3]: Workaround MSI bug on 5714/5780. > > A hardware bug was revealed after a recent PCI MSI patch was made to > always disable legacy INTX when enabling MSI. The 5714/5780 chips > will not generate MSI when INTX is

[TG3]: Workaround MSI bug on 5714/5780.

2007-09-05 Thread Michael Chan
[TG3]: Workaround MSI bug on 5714/5780. A hardware bug was revealed after a recent PCI MSI patch was made to always disable legacy INTX when enabling MSI. The 5714/5780 chips will not generate MSI when INTX is disabled, causing MSI failure messages to be reported, and another patch was made to