Re: [SC92031]: Fix priv->lock context

2007-04-09 Thread David Miller
vid Miller wrote: > >>> Where is the patch? :-) > >>> > >>> Second time you've done this in two days Herbert, tsk tsk :))) > >> The patch was so easy that it was left as an exercise to the reader :) > >> > >> [SC92031]: Fix priv->lock context > &g

Re: [SC92031]: Fix priv->lock context

2007-04-09 Thread Jeff Garzik
left as an exercise to the reader :) [SC92031]: Fix priv->lock context The spin_lock calls made in dev->open and dev->close must disable BH since open/close are made in process context. Conversely, the call in dev->hard_start_xmit does not need to disable BH since it is already exe

Re: [SC92031]: Fix priv->lock context

2007-04-09 Thread David Miller
The patch was so easy that it was left as an exercise to the reader :) > > [SC92031]: Fix priv->lock context > > The spin_lock calls made in dev->open and dev->close must disable > BH since open/close are made in process context. Conversely, the > call in dev->hard_star

Re: [SC92031]: Fix priv->lock context

2007-04-05 Thread Antonino A. Daplas
was too much for me :-) > > [SC92031]: Fix priv->lock context > > The spin_lock calls made in dev->open and dev->close must disable > BH since open/close are made in process context. Conversely, the > call in dev->hard_start_xmit does not need to disable BH since it

Re: [SC92031]: Fix priv->lock context

2007-04-05 Thread Herbert Xu
On Thu, Apr 05, 2007 at 09:59:29AM -0700, David Miller wrote: > > Where is the patch? :-) > > Second time you've done this in two days Herbert, tsk tsk :))) The patch was so easy that it was left as an exercise to the reader :) [SC92031]: Fix priv->lock context The spin_lo

Re: [SC92031]: Fix priv->lock context

2007-04-05 Thread David Miller
drivers/net/sc92031.c in rc5-mm4. > > Actually, this looks like a latent bug in sc92031. It's calling > spin_lock in the dev->open function on a lock that's held in BH > context. > > [SC92031]: Fix priv->lock context Where is the patch? :-) Second time you've

[SC92031]: Fix priv->lock context (was: 2.6.21-rc5-mm4)

2007-04-05 Thread Herbert Xu
pin_lock in the dev->open function on a lock that's held in BH context. [SC92031]: Fix priv->lock context The spin_lock calls made in dev->open and dev->close must disable BH since open/close are made in process context. Conversely, the call in dev->hard_start_xmit does not