Re: [RFC v2 net-next 06/10] net/sched: Introduce the TBS Qdisc

2018-01-23 Thread Jesus Sanchez-Palencia
Hi, On 01/18/2018 05:35 AM, Jamal Hadi Salim wrote: > On 18-01-17 06:06 PM, Jesus Sanchez-Palencia wrote: >> From: Vinicius Costa Gomes >> >> TBS (Time Based Scheduler) uses the information added earlier in this >> series (the socket option SO_TXTIME and the new role of >> sk_buff->tstamp) to sc

Re: [RFC v2 net-next 06/10] net/sched: Introduce the TBS Qdisc

2018-01-23 Thread Jesus Sanchez-Palencia
Hi, On 01/18/2018 05:44 AM, Jamal Hadi Salim wrote: > One more comment: > Probably try to run a test with a very small delta with > no offload (probably using something like prio as the root qdisc) > and dump the stats. > My gut feeling is your accounting of the backlog in particular is off. Yo

Re: [RFC v2 net-next 06/10] net/sched: Introduce the TBS Qdisc

2018-01-19 Thread Willem de Bruijn
On Wed, Jan 17, 2018 at 6:06 PM, Jesus Sanchez-Palencia wrote: > From: Vinicius Costa Gomes > > TBS (Time Based Scheduler) uses the information added earlier in this > series (the socket option SO_TXTIME and the new role of > sk_buff->tstamp) to schedule traffic transmission based on absolute > t

Re: [RFC v2 net-next 06/10] net/sched: Introduce the TBS Qdisc

2018-01-18 Thread Richard Cochran
On Thu, Jan 18, 2018 at 08:35:18AM -0500, Jamal Hadi Salim wrote: > 1) iproute2: Avoid magic numbers like 1 or 11 please; "offload" > (without 1) and "TAI" will be more human friendly. Yes, and for the clockid, the program should accept CLOCK_REALTIME or CLOCK_TAI for the hard coded SYS-V IDs or /

Re: [RFC v2 net-next 06/10] net/sched: Introduce the TBS Qdisc

2018-01-18 Thread Jamal Hadi Salim
One more comment: Probably try to run a test with a very small delta with no offload (probably using something like prio as the root qdisc) and dump the stats. My gut feeling is your accounting of the backlog in particular is off. cheers, jamal On 18-01-18 08:35 AM, Jamal Hadi Salim wrote: On 1

Re: [RFC v2 net-next 06/10] net/sched: Introduce the TBS Qdisc

2018-01-18 Thread Jamal Hadi Salim
On 18-01-17 06:06 PM, Jesus Sanchez-Palencia wrote: From: Vinicius Costa Gomes TBS (Time Based Scheduler) uses the information added earlier in this series (the socket option SO_TXTIME and the new role of sk_buff->tstamp) to schedule traffic transmission based on absolute time. For some worklo

[RFC v2 net-next 06/10] net/sched: Introduce the TBS Qdisc

2018-01-17 Thread Jesus Sanchez-Palencia
From: Vinicius Costa Gomes TBS (Time Based Scheduler) uses the information added earlier in this series (the socket option SO_TXTIME and the new role of sk_buff->tstamp) to schedule traffic transmission based on absolute time. For some workloads, just bandwidth enforcement is not enough, and pre