Re: [RFC patch] sctp: sctp_generate_fwdtsn: Initialize sctp_fwdtsn_skip array, neatening

2015-07-06 Thread Neil Horman
On Fri, Jul 03, 2015 at 09:41:41AM -0700, Joe Perches wrote: > On Fri, 2015-07-03 at 07:51 -0400, Neil Horman wrote: > > On Thu, Jul 02, 2015 at 02:54:56PM -0700, Joe Perches wrote: > > > It's not clear to me that the sctp_fwdtsn_skip array is > > > always initialized when used. > > > > > > It is

Re: [RFC patch] sctp: sctp_generate_fwdtsn: Initialize sctp_fwdtsn_skip array, neatening

2015-07-03 Thread Joe Perches
On Fri, 2015-07-03 at 07:51 -0400, Neil Horman wrote: > On Thu, Jul 02, 2015 at 02:54:56PM -0700, Joe Perches wrote: > > It's not clear to me that the sctp_fwdtsn_skip array is > > always initialized when used. > > > > It is appropriate to initialize the array to 0? > > > > This patch initializes

Re: [RFC patch] sctp: sctp_generate_fwdtsn: Initialize sctp_fwdtsn_skip array, neatening

2015-07-03 Thread Neil Horman
On Thu, Jul 02, 2015 at 02:54:56PM -0700, Joe Perches wrote: > It's not clear to me that the sctp_fwdtsn_skip array is > always initialized when used. > > It is appropriate to initialize the array to 0? > > This patch initializes the array too 0 and moves the > local variables into the blocks whe

[RFC patch] sctp: sctp_generate_fwdtsn: Initialize sctp_fwdtsn_skip array, neatening

2015-07-02 Thread Joe Perches
It's not clear to me that the sctp_fwdtsn_skip array is always initialized when used. It is appropriate to initialize the array to 0? This patch initializes the array too 0 and moves the local variables into the blocks where used. It also does some miscellaneous neatening by using continue; and