Re: [RFC net 1/2] net: set skb hash for IP6 TCP reset packet

2017-07-18 Thread Shaohua Li
On Mon, Jul 17, 2017 at 09:02:57PM -0700, Eric Dumazet wrote: > On Mon, 2017-07-17 at 14:53 -0700, Shaohua Li wrote: > > On Mon, Jul 17, 2017 at 01:51:51AM -0700, Eric Dumazet wrote: > > > On Thu, 2017-07-13 at 10:56 -0700, Shaohua Li wrote: > > > > From: Shaohua Li > > > > > > > > Please see bel

Re: [RFC net 1/2] net: set skb hash for IP6 TCP reset packet

2017-07-17 Thread Eric Dumazet
On Mon, 2017-07-17 at 14:53 -0700, Shaohua Li wrote: > On Mon, Jul 17, 2017 at 01:51:51AM -0700, Eric Dumazet wrote: > > On Thu, 2017-07-13 at 10:56 -0700, Shaohua Li wrote: > > > From: Shaohua Li > > > > > > Please see below tcpdump output: > > > > > The tcp reset packet has a different flowlab

Re: [RFC net 1/2] net: set skb hash for IP6 TCP reset packet

2017-07-17 Thread Shaohua Li
On Mon, Jul 17, 2017 at 01:51:51AM -0700, Eric Dumazet wrote: > On Thu, 2017-07-13 at 10:56 -0700, Shaohua Li wrote: > > From: Shaohua Li > > > > Please see below tcpdump output: > > > The tcp reset packet has a different flowlabel, which causes our router > > doesn't correctly close tcp connect

Re: [RFC net 1/2] net: set skb hash for IP6 TCP reset packet

2017-07-17 Thread Florent Fourcot
Eric Dumazet wrote: I am a bit unsure why we need to add yet another field in TCP timewait structure, since : 1) flowlabel can vary during a TCP flow lifetime. 2) flowlabel is different unde synflood (each syncookie gets a random flowlabel), and if 3rd packet comes back from the client to finish

Re: [RFC net 1/2] net: set skb hash for IP6 TCP reset packet

2017-07-17 Thread Eric Dumazet
On Thu, 2017-07-13 at 10:56 -0700, Shaohua Li wrote: > From: Shaohua Li > > Please see below tcpdump output: > The tcp reset packet has a different flowlabel, which causes our router > doesn't correctly close tcp connection. This looks a bug in your router, because (IPv6 only) flowlabel is not

[RFC net 1/2] net: set skb hash for IP6 TCP reset packet

2017-07-13 Thread Shaohua Li
From: Shaohua Li Please see below tcpdump output: 21:00:48.109122 IP6 (flowlabel 0x43304, hlim 64, next-header TCP (6) payload length: 40) fec0::5054:ff:fe12:3456.55804 > fec0::5054:ff:fe12:3456.: Flags [S], cksum 0x0529 (incorrect -> 0xf56c), seq 3282214508, win 43690, options [mss 65476,