Re: [RFC net-next 3/6] net: xdp: make the stack take care of the tear down

2017-11-24 Thread Jakub Kicinski
On Sat, 25 Nov 2017 00:24:50 +0100, Daniel Borkmann wrote: > > +static void dev_xdp_uninstall(struct net_device *dev) > > +{ > > + struct netdev_bpf xdp; > > + bpf_op_t ndo_bpf; > > Can you add a comment here stating that generic XDP does not > need to be handled since we drop the prog from

Re: [RFC net-next 3/6] net: xdp: make the stack take care of the tear down

2017-11-24 Thread Daniel Borkmann
On 11/24/2017 03:36 AM, Jakub Kicinski wrote: > Since day one of XDP drivers had to remember to free the program > on the remove path. This leads to code duplication and is error > prone. Make the stack query the installed programs on unregister > and if something is installed, remove the program

[RFC net-next 3/6] net: xdp: make the stack take care of the tear down

2017-11-23 Thread Jakub Kicinski
Since day one of XDP drivers had to remember to free the program on the remove path. This leads to code duplication and is error prone. Make the stack query the installed programs on unregister and if something is installed, remove the program. Because the remove will now be called before notifi