Re: [RFC net-next 1/2] net: sched: refactor reinsert action

2019-06-18 Thread Jakub Kicinski
On Mon, 17 Jun 2019 19:43:53 +0100, Edward Cree wrote: > On 14/06/2019 15:33, John Hurley wrote: > > Instead of > > returning TC_ACT_REINSERT, change the type to the new TC_ACT_CONSUMED > > which tells the caller that the packet has been stolen by another process > > and that no consume call is req

Re: [RFC net-next 1/2] net: sched: refactor reinsert action

2019-06-17 Thread John Hurley
On Mon, Jun 17, 2019 at 7:44 PM Edward Cree wrote: > > On 14/06/2019 15:33, John Hurley wrote: > > Instead of > > returning TC_ACT_REINSERT, change the type to the new TC_ACT_CONSUMED > > which tells the caller that the packet has been stolen by another process > > and that no consume call is requ

Re: [RFC net-next 1/2] net: sched: refactor reinsert action

2019-06-17 Thread Edward Cree
On 14/06/2019 15:33, John Hurley wrote: > Instead of > returning TC_ACT_REINSERT, change the type to the new TC_ACT_CONSUMED > which tells the caller that the packet has been stolen by another process > and that no consume call is required. Possibly a dumb question, but why does this need a new CON

[RFC net-next 1/2] net: sched: refactor reinsert action

2019-06-14 Thread John Hurley
The TC_ACT_REINSERT return type was added as an in-kernel only option to allow a packet ingress or egress redirect. This is used to avoid unnecessary skb clones in situations where they are not required. If a TC hook returns this code then the packet is 'reinserted' and no skb consume is carried ou