Re: [RFC net-next 1/2] net: dsa: add Realtek RTL8366S switch tag

2021-03-01 Thread Linus Walleij
On Sun, Feb 28, 2021 at 12:32 PM DENG Qingfang wrote: > On Sun, Feb 28, 2021 at 7:47 AM Linus Walleij > wrote: > > > > I names the previous protocol "RTL4 A" after a 4-byte tag > > with protocol indicted as "A", what about naming this > > "RTL2 9" in the same vein? It will be good if some other

Re: [RFC net-next 1/2] net: dsa: add Realtek RTL8366S switch tag

2021-02-28 Thread DENG Qingfang
On Sun, Feb 28, 2021 at 7:47 AM Linus Walleij wrote: > > I names the previous protocol "RTL4 A" after a 4-byte tag > with protocol indicted as "A", what about naming this > "RTL2 9" in the same vein? It will be good if some other > switch is using the same protocol. (If any...) RTL8306 uses 0x9 t

Re: [RFC net-next 1/2] net: dsa: add Realtek RTL8366S switch tag

2021-02-27 Thread Linus Walleij
On Wed, Feb 17, 2021 at 7:21 AM DENG Qingfang wrote: > Add support for Realtek RTL8366S switch tag > > Signed-off-by: DENG Qingfang I understand this switch tag now sorry for confusion. > @@ -104,6 +104,12 @@ config NET_DSA_TAG_RTL4_A > Realtek switches with 4 byte protocol A tags, s

Re: [RFC net-next 1/2] net: dsa: add Realtek RTL8366S switch tag

2021-02-17 Thread DENG Qingfang
On Wed, Feb 17, 2021 at 6:55 PM Linus Walleij wrote: > > I suppose this switch can just use the existing RTL4 A tag > code after the recent patch so this one is not needed? No. Different protocol (0x9 instead of 0xA) and different xmit tag format (port bit mask instead of port number). Please tak

Re: [RFC net-next 1/2] net: dsa: add Realtek RTL8366S switch tag

2021-02-17 Thread Heiner Kallweit
On 17.02.2021 12:01, Linus Walleij wrote: > On Wed, Feb 17, 2021 at 8:08 AM Heiner Kallweit wrote: > >>> +#define RTL8366S_HDR_LEN 4 >>> +#define RTL8366S_ETHERTYPE 0x8899 >> >> I found this protocol referenced as Realtek Remote Control Protocol (RRCP) >> and it seems to be used by few Real

Re: [RFC net-next 1/2] net: dsa: add Realtek RTL8366S switch tag

2021-02-17 Thread Linus Walleij
On Wed, Feb 17, 2021 at 8:08 AM Heiner Kallweit wrote: > > +#define RTL8366S_HDR_LEN 4 > > +#define RTL8366S_ETHERTYPE 0x8899 > > I found this protocol referenced as Realtek Remote Control Protocol (RRCP) > and it seems to be used by few Realtek chips. Not sure whether this > protocol is of

Re: [RFC net-next 1/2] net: dsa: add Realtek RTL8366S switch tag

2021-02-17 Thread Linus Walleij
On Wed, Feb 17, 2021 at 7:21 AM DENG Qingfang wrote: > Add support for Realtek RTL8366S switch tag > > Signed-off-by: DENG Qingfang I suppose this switch can just use the existing RTL4 A tag code after the recent patch so this one is not needed? Yours, Linus Walleij

Re: [RFC net-next 1/2] net: dsa: add Realtek RTL8366S switch tag

2021-02-16 Thread Heiner Kallweit
On 17.02.2021 07:21, DENG Qingfang wrote: > Add support for Realtek RTL8366S switch tag > > Signed-off-by: DENG Qingfang > --- > include/net/dsa.h | 2 + > net/dsa/Kconfig| 6 +++ > net/dsa/Makefile | 1 + > net/dsa/tag_rtl8366s.c | 98 ++

[RFC net-next 1/2] net: dsa: add Realtek RTL8366S switch tag

2021-02-16 Thread DENG Qingfang
Add support for Realtek RTL8366S switch tag Signed-off-by: DENG Qingfang --- include/net/dsa.h | 2 + net/dsa/Kconfig| 6 +++ net/dsa/Makefile | 1 + net/dsa/tag_rtl8366s.c | 98 ++ 4 files changed, 107 insertions(+) create mode 1006